<div dir="ltr">Lang, this change adds compile warnings on gcc 4.8 since you compare an unsigned >= 0 (tautology)<div><br></div><div>Eli</div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Wed, Feb 12, 2014 at 4:16 PM, Lang Hames <span dir="ltr"><<a href="mailto:lhames@gmail.com" target="_blank">lhames@gmail.com</a>></span> wrote:<br>

<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: lhames<br>
Date: Wed Feb 12 18:16:36 2014<br>
New Revision: 201277<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=201277&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=201277&view=rev</a><br>
Log:<br>
The new MCJIT C-API unit test is generating objects without constant data<br>
sections, at least on MachO. Relax expectations to keep the bots green while I<br>
investigate.<br>
<br>
<br>
Modified:<br>
    llvm/trunk/unittests/ExecutionEngine/MCJIT/MCJITCAPITest.cpp<br>
<br>
Modified: llvm/trunk/unittests/ExecutionEngine/MCJIT/MCJITCAPITest.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/unittests/ExecutionEngine/MCJIT/MCJITCAPITest.cpp?rev=201277&r1=201276&r2=201277&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/unittests/ExecutionEngine/MCJIT/MCJITCAPITest.cpp?rev=201277&r1=201276&r2=201277&view=diff</a><br>


==============================================================================<br>
--- llvm/trunk/unittests/ExecutionEngine/MCJIT/MCJITCAPITest.cpp (original)<br>
+++ llvm/trunk/unittests/ExecutionEngine/MCJIT/MCJITCAPITest.cpp Wed Feb 12 18:16:36 2014<br>
@@ -322,6 +322,6 @@ TEST_F(MCJITCAPITest, reserve_allocation<br>
   EXPECT_LE(MM->UsedDataSizeRO, MM->ReservedDataSizeRO);<br>
   EXPECT_LE(MM->UsedDataSizeRW, MM->ReservedDataSizeRW);<br>
   EXPECT_TRUE(MM->UsedCodeSize > 0);<br>
-  EXPECT_TRUE(MM->UsedDataSizeRO > 0);<br>
+  EXPECT_TRUE(MM->UsedDataSizeRO >= 0);<br>
   EXPECT_TRUE(MM->UsedDataSizeRW > 0);<br>
 }<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div>