<div dir="ltr"><div class="gmail_extra">This got reverted as <span style="font-family:arial,sans-serif;font-size:13px">r200375.</span></div><div class="gmail_extra"><span style="font-family:arial,sans-serif;font-size:13px"><br>
</span></div><div class="gmail_extra"><span style="color:rgb(80,0,80)">28 янв. 2014 г. 22:23 пользователь "NAKAMURA Takumi" <</span><a href="mailto:geek4civic@gmail.com" target="_blank" class="cremed">geek4civic@gmail.com</a><span style="color:rgb(80,0,80)">> написал:</span><div style="color:rgb(80,0,80)">
<br type="attribution"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">Reverted in r200375. It broke many llvm and clang tests, at least in msc17 builder.<br>
</blockquote><div><br></div><div>It would help a bit if you also gave a link to the report.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
================<br>Comment at: lib/CodeGen/AsmPrinter/AsmPrinter.cpp:198<br>@@ -195,3 +197,3 @@<br> if (MAI->doesSupportDebugInformation()) {<br>- DD = new DwarfDebug(this, &M);<br>- Handlers.push_back(HandlerInfo(DD, DbgTimerName, DWARFGroupName));<br>
+ if (Triple(TM.getTargetTriple()).getOS() == Triple::Win32) {<br>+ Handlers.push_back(HandlerInfo(new WinCodeViewLineTables(this),<br>----------------<br>You should tweak more other tests (also in clang/test/CodeGen/ !) when you suppressed llvm::DwarfDebug.<br>
<br>You can reproduce such a case with LLVM_DEFAULT_TARGET_TRIPLE:=i686-pc-win32<br><br><br><a href="http://llvm-reviews.chandlerc.com/D2232" target="_blank" class="cremed">http://llvm-reviews.chandlerc.com/D2232</a></blockquote>
<div><br></div><div> </div></div></div><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<div class=""><div class="h5"><div class="gmail_extra"><div class="gmail_quote">On Tue, Jan 28, 2014 at 10:54 PM, Timur Iskhodzhanov <span dir="ltr"><<a href="mailto:timurrrr@google.com" target="_blank" class="cremed">timurrrr@google.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><p dir="ltr">Sorry for the breakage and not reverting it earlier - I don't think I got an email about the failure.</p>
<p dir="ltr">How do you recommend me to tweak them?<br>The default triple on windows shouldn't imply dwarf. I think running these tests with a -cygwin/-mingw32 triple is reasonable, as it is probably (?) reasonable to run them with the default triple on non-Windows architectures.</p>
</blockquote></div></div></div></div></blockquote>2014-01-29 Reid Kleckner <span dir="ltr"><<a href="mailto:rnk@google.com" target="_blank" class="cremed">rnk@google.com</a>></span><br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<div dir="ltr">I'm pretty sure Timur is testing with a triple of i686-pc-win32.</div></blockquote><div><br></div><div>It's a bit more complex than that: I only ran new tests on i686-pc-win32 as I don't have the workstation fully set up.</div>
<div>I ran the whole suite on my Mac laptop expecting it to have enough coverage. Oh, well.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<div dir="ltr"><div>One way to tweak the tests is to use -triple %itanium_abi_triple, although that's abusing the terminology a little bit. It's better than using an explicit triple because you don't over specify the test requirements. <br>
</div></div></blockquote><div><br></div><div>I've looked at the failures and most of them seem to have an implicit triple.</div><div><br></div><div>I'm pretty sure we want to exclude some tests entirely for Win runs.</div>
<div>For example, it's almost certainly wrong to run MIPS or SPARC tests on Windows with an implicit triple?</div><div><br></div><div>For the other tests, I plan to add something like "-triple %dwarf_triple" that works similar to %itanium_abi_triple, i.e. replace win32 with mingw32.</div>
</div></div></div>