<div dir="ltr">I'd name it IMAGE_DLL_CHARACTERISTICS_HIGH_ENTROPY_VA to make it match the editbin and link, it's shorter too :)<div><br></div><div>-- </div><div>David Majnemer</div></div><div class="gmail_extra"><br>
<br><div class="gmail_quote">On Sat, Jan 25, 2014 at 9:05 PM, Rui Ueyama <span dir="ltr"><<a href="mailto:ruiu@google.com" target="_blank">ruiu@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Author: ruiu<br>
Date: Sat Jan 25 23:05:23 2014<br>
New Revision: 200121<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=200121&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=200121&view=rev</a><br>
Log:<br>
COFF: Add a missing enum value for high entropy ASLR.<br>
<br>
That bit is not documented in the PE/COFF spec published by Microsoft, so we<br>
don't know the official name of it. I named this bit<br>
IMAGE_DLL_CHARACTERISTICS_HIGH_ENTROPY_VIRTUAL_ADDRESS because the bit is<br>
reported as "high entropy virtual address" by dumpbin.exe,<br>
<br>
Modified:<br>
    llvm/trunk/include/llvm/Support/COFF.h<br>
    llvm/trunk/test/tools/llvm-readobj/peplus.test<br>
    llvm/trunk/tools/llvm-readobj/COFFDumper.cpp<br>
<br>
Modified: llvm/trunk/include/llvm/Support/COFF.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Support/COFF.h?rev=200121&r1=200120&r2=200121&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Support/COFF.h?rev=200121&r1=200120&r2=200121&view=diff</a><br>

==============================================================================<br>
--- llvm/trunk/include/llvm/Support/COFF.h (original)<br>
+++ llvm/trunk/include/llvm/Support/COFF.h Sat Jan 25 23:05:23 2014<br>
@@ -531,6 +531,8 @@ namespace COFF {<br>
   };<br>
<br>
   enum DLLCharacteristics {<br>
+    /// ASLR with 64 bit address space.<br>
+    IMAGE_DLL_CHARACTERISTICS_HIGH_ENTROPY_VIRTUAL_ADDRESS = 0x0020,<br>
     /// DLL can be relocated at load time.<br>
     IMAGE_DLL_CHARACTERISTICS_DYNAMIC_BASE = 0x0040,<br>
     /// Code integrity checks are enforced.<br>
<br>
Modified: llvm/trunk/test/tools/llvm-readobj/peplus.test<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/tools/llvm-readobj/peplus.test?rev=200121&r1=200120&r2=200121&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/test/tools/llvm-readobj/peplus.test?rev=200121&r1=200120&r2=200121&view=diff</a><br>

==============================================================================<br>
--- llvm/trunk/test/tools/llvm-readobj/peplus.test (original)<br>
+++ llvm/trunk/test/tools/llvm-readobj/peplus.test Sat Jan 25 23:05:23 2014<br>
@@ -37,6 +37,7 @@ CHECK:   SizeOfHeaders: 512<br>
 CHECK:   Subsystem: IMAGE_SUBSYSTEM_WINDOWS_CUI (0x3)<br>
 CHECK:   Subsystem [ (0x8160)<br>
 CHECK:     IMAGE_DLL_CHARACTERISTICS_DYNAMIC_BASE (0x40)<br>
+CHECK:     IMAGE_DLL_CHARACTERISTICS_HIGH_ENTROPY_VIRTUAL_ADDRESS (0x20)<br>
 CHECK:     IMAGE_DLL_CHARACTERISTICS_NX_COMPAT (0x100)<br>
 CHECK:     IMAGE_DLL_CHARACTERISTICS_TERMINAL_SERVER_AWARE (0x8000)<br>
 CHECK:   ]<br>
<br>
Modified: llvm/trunk/tools/llvm-readobj/COFFDumper.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-readobj/COFFDumper.cpp?rev=200121&r1=200120&r2=200121&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-readobj/COFFDumper.cpp?rev=200121&r1=200120&r2=200121&view=diff</a><br>

==============================================================================<br>
--- llvm/trunk/tools/llvm-readobj/COFFDumper.cpp (original)<br>
+++ llvm/trunk/tools/llvm-readobj/COFFDumper.cpp Sat Jan 25 23:05:23 2014<br>
@@ -281,6 +281,8 @@ static const EnumEntry<COFF::WindowsSubs<br>
 };<br>
<br>
 static const EnumEntry<COFF::DLLCharacteristics> PEDLLCharacteristics[] = {<br>
+  LLVM_READOBJ_ENUM_ENT(COFF,<br>
+                        IMAGE_DLL_CHARACTERISTICS_HIGH_ENTROPY_VIRTUAL_ADDRESS),<br>
   LLVM_READOBJ_ENUM_ENT(COFF, IMAGE_DLL_CHARACTERISTICS_DYNAMIC_BASE         ),<br>
   LLVM_READOBJ_ENUM_ENT(COFF, IMAGE_DLL_CHARACTERISTICS_FORCE_INTEGRITY      ),<br>
   LLVM_READOBJ_ENUM_ENT(COFF, IMAGE_DLL_CHARACTERISTICS_NX_COMPAT            ),<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div>