<div dir="ltr"><br><div class="gmail_extra"><br><br><div class="gmail_quote">On Thu, Jan 23, 2014 at 8:44 PM, Stephen Crane <span dir="ltr"><<a href="mailto:sjcrane@uci.edu" target="_blank">sjcrane@uci.edu</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div><div>I can't really speak to the first two points besides suggesting that we have working code ready to go for a useful tool to add to users' security toolbox.</div>
</div></div></blockquote><div><br></div><div>In the original thread, there didn't seem to be any consensus as to the usefulness of this though. That's the main reason I'm asking. </div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr"><div><div> However, this does lead to your third point... We've had off-list discussions with several different people who are interested in using this, assuming it fits their needs after testing, including Google and OpenBSD.</div>
</div></div></blockquote><div><br></div><div>Cool, let's wait for the verdict "after testing" before deciding to pull anything upstream.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr"><div><div> As for me, I'm certainly still on board with the work (and maintenance). Julian, a collaborator of mine at UC Irvine, is also helping put the finishing touches on the patch, and Andrei is also involved as needed since he wrote a good deal of the code for this.<br>
</div></div></div></blockquote><div><br></div><div>In the meantime, one thing I'd like to suggest is for your team is to submit some smaller patches (small bug fixes, cleanups etc.) that you've run into while working on LLVM (I'm sure you've run into things while working with LLVM! We have plenty of things that need attention!).</div>
<div><br></div><div>That way you can get familiar with the community coding conventions (there's *a lot* of issues with the current patch) and micro-level review process before diving into a "big" feature like this (one that entails ongoing maintenance and a certain level of community involvement). It just seems like proposing this large of a chunk of code while also adding a foreign dependency is jumping in the deep end for new contributors :)</div>
<div> <br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div><div>
<br></div><div>Perhaps an email to the llvmdev list resurrecting the original thread would be a good idea, since people were interested in seeing actual code. I'll go ahead and do that so perhaps we can get more input.<br>
</div></div></div></blockquote><div><br></div><div>Can't hurt.</div><div><br></div><div>-- Sean Silva</div><div><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr"><div><div>
</div>
<div>
<br></div>I agree, splitting the RNG would be a good idea.<span class="HOEnZb"><font color="#888888"><br><br></font></span></div><span class="HOEnZb"><font color="#888888">- stephen<br></font></span></div><div class="HOEnZb">
<div class="h5"><div class="gmail_extra"><br><br><div class="gmail_quote">On Thu, Jan 23, 2014 at 5:08 PM, Sean Silva <span dir="ltr"><<a href="mailto:silvas@purdue.edu" target="_blank">silvas@purdue.edu</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Was there ever consensus that we want to maintain this in LLVM? I just looked back at the original thread on llvmdev, and it looked like basically:<div>
<br><div>- A number of security folks having an inconclusive, wandering, back-and-forth discussion about various security things that should have been done on a security mailing list.<br>
</div><div><div>- Lots of "this seems maybe interesting, but ..." with the "but ..." not clearly addressed in any way. Often times the "but ..." was an alternative approach that would be more maintainable, effective, and/or fit in better with existing deployment processes.</div>
</div><div>- No concrete use cases. Who is going to be deploying this? If nobody is deploying, then how do we know it will be maintained? It seems like the initial patch submitter has already jumped ship on this patch; doesn't exactly inspire confidence.</div>
<div><br></div><div>It seems like basically nobody who participated in the original discussion on llvmdev is participating in this patch review either. Especially the people who had doubts don't seem to be participating; those doubts need to be addressed.</div>
<div><br></div><div>Also, at the very least, adding the RNG should be split out into a separate patch.</div><span><font color="#888888"><div><br></div><div>-- Sean Silva</div></font></span></div></div><div class="gmail_extra">
<br><br><div class="gmail_quote"><div><div>On Thu, Jan 23, 2014 at 6:08 PM, Julian Lettner <span dir="ltr"><<a href="mailto:julian.lettner@gmail.com" target="_blank">julian.lettner@gmail.com</a>></span> wrote:<br>
</div></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div> Move patch forward to ToT.<br>
<br>
Hi rinon, ahomescu,<br>
<br>
<a href="http://llvm-reviews.chandlerc.com/D1802" target="_blank">http://llvm-reviews.chandlerc.com/D1802</a><br>
<br>
CHANGE SINCE LAST DIFF<br>
<a href="http://llvm-reviews.chandlerc.com/D1802?vs=6581&id=6621#toc" target="_blank">http://llvm-reviews.chandlerc.com/D1802?vs=6581&id=6621#toc</a><br>
<div><br>
Files:<br>
include/llvm/CodeGen/CommandFlags.h<br>
include/llvm/MC/MCRegisterInfo.h<br>
include/llvm/Support/RandomNumberGenerator.h<br>
include/llvm/Target/TargetOptions.h<br>
lib/CodeGen/LLVMBuild.txt<br>
</div><div> lib/CodeGen/SelectionDAG/ScheduleDAGRRList.cpp<br>
lib/LTO/LTOCodeGenerator.cpp<br>
lib/LTO/LTOModule.cpp<br>
lib/Support/CMakeLists.txt<br>
lib/Support/RandomNumberGenerator.cpp<br>
lib/Target/X86/CMakeLists.txt<br>
lib/Target/X86/NOPInsertion.cpp<br>
lib/Target/X86/X86.h<br>
lib/Target/X86/X86TargetMachine.cpp<br>
test/CodeGen/X86/nop-insert-percentage.ll<br>
test/CodeGen/X86/nop-insert.ll<br>
test/CodeGen/X86/sched-rnd-test.ll<br>
</div> tools/llc/llc.cpp<br>
tools/llvm-lto/llvm-lto.cpp<br>
tools/lto/lto.cpp<br>
tools/opt/opt.cpp<br>
<br></div></div><div>_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
<br></div></blockquote></div><br></div>
</blockquote></div><br></div>
</div></div></blockquote></div><br></div></div>