<div dir="ltr">Was there ever consensus that we want to maintain this in LLVM? I just looked back at the original thread on llvmdev, and it looked like basically:<div><br><div>- A number of security folks having an inconclusive, wandering, back-and-forth discussion about various security things that should have been done on a security mailing list.<br>

</div><div><div>- Lots of "this seems maybe interesting, but ..." with the "but ..." not clearly addressed in any way. Often times the "but ..." was an alternative approach that would be more maintainable, effective, and/or fit in better with existing deployment processes.</div>
</div><div>- No concrete use cases. Who is going to be deploying this? If nobody is deploying, then how do we know it will be maintained? It seems like the initial patch submitter has already jumped ship on this patch; doesn't exactly inspire confidence.</div>
<div><br></div><div>It seems like basically nobody who participated in the original discussion on llvmdev is participating in this patch review either. Especially the people who had doubts don't seem to be participating; those doubts need to be addressed.</div>

<div><br></div><div>Also, at the very least, adding the RNG should be split out into a separate patch.</div><div><br></div><div>-- Sean Silva</div></div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Thu, Jan 23, 2014 at 6:08 PM, Julian Lettner <span dir="ltr"><<a href="mailto:julian.lettner@gmail.com" target="_blank">julian.lettner@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">  Move patch forward to ToT.<br>
<br>
Hi rinon, ahomescu,<br>
<br>
<a href="http://llvm-reviews.chandlerc.com/D1802" target="_blank">http://llvm-reviews.chandlerc.com/D1802</a><br>
<br>
CHANGE SINCE LAST DIFF<br>
  <a href="http://llvm-reviews.chandlerc.com/D1802?vs=6581&id=6621#toc" target="_blank">http://llvm-reviews.chandlerc.com/D1802?vs=6581&id=6621#toc</a><br>
<div class="im"><br>
Files:<br>
  include/llvm/CodeGen/CommandFlags.h<br>
  include/llvm/MC/MCRegisterInfo.h<br>
  include/llvm/Support/RandomNumberGenerator.h<br>
  include/llvm/Target/TargetOptions.h<br>
  lib/CodeGen/LLVMBuild.txt<br>
</div><div class="im">  lib/CodeGen/SelectionDAG/ScheduleDAGRRList.cpp<br>
  lib/LTO/LTOCodeGenerator.cpp<br>
  lib/LTO/LTOModule.cpp<br>
  lib/Support/CMakeLists.txt<br>
  lib/Support/RandomNumberGenerator.cpp<br>
  lib/Target/X86/CMakeLists.txt<br>
  lib/Target/X86/NOPInsertion.cpp<br>
  lib/Target/X86/X86.h<br>
  lib/Target/X86/X86TargetMachine.cpp<br>
  test/CodeGen/X86/nop-insert-percentage.ll<br>
  test/CodeGen/X86/nop-insert.ll<br>
  test/CodeGen/X86/sched-rnd-test.ll<br>
</div>  tools/llc/llc.cpp<br>
  tools/llvm-lto/llvm-lto.cpp<br>
  tools/lto/lto.cpp<br>
  tools/opt/opt.cpp<br>
<br>_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
<br></blockquote></div><br></div>