<div dir="ltr">Hi Kevin,<div><br></div><div>A minor nit with this patch: There are spelling mistakes in both the comments and the names of variables. Please could you quickly fix them so it is easier to maintain?</div><div>
<br></div><div><span style="color:rgb(0,0,0);font-family:sans-serif;font-size:13px;background-color:rgb(255,255,119)"> // Check whether a shuffle_vecotor could be presented as conact_vector.</span><br></div><div><span style="color:rgb(0,0,0);font-family:sans-serif;font-size:13px;background-color:rgb(255,255,119)"><br>
</span></div><div><font color="#000000" face="sans-serif">shuffle_vector, concat_vector.</font></div><div><font color="#000000" face="sans-serif"><br></font></div><div><span style="color:rgb(0,0,0);font-family:sans-serif;font-size:13px;background-color:rgb(170,255,170)">bool isContactVector = true;</span><font color="#000000" face="sans-serif"><br>
</font></div><div><span style="color:rgb(0,0,0);font-family:sans-serif;font-size:13px;background-color:rgb(170,255,170)"><br></span></div><div><font color="#000000" face="sans-serif">isConcatVector</font></div><div><font color="#000000" face="sans-serif"><br>
</font></div><div><table cellspacing="0" cellpadding="0" style="width:1649px;margin:0px;border:none;color:rgb(0,0,0);font-family:sans-serif;font-size:medium"><tbody><tr style="vertical-align:top"><td class="" style="vertical-align:top;background-color:rgb(170,255,170);font-family:sans-serif;font-size:smaller">
   if (isConactVector(Op, DAG, V1, V2, &ShuffleMask[0], Res))</td></tr><tr style="vertical-align:top"></tr></tbody></table><br></div><div><font color="#000000">isConcatVector</font></div><div><font color="#000000"><br>
</font></div><div><font color="#000000"><br></font></div><div><font color="#000000">Cheers,</font></div><div><font color="#000000"><br></font></div><div><font color="#000000">James</font></div></div><div class="gmail_extra">
<br><br><div class="gmail_quote">On 22 January 2014 03:47, Jiangning Liu <span dir="ltr"><<a href="mailto:liujiangning1@gmail.com" target="_blank">liujiangning1@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr"><div class="gmail_default" style="font-family:arial,helvetica,sans-serif;font-size:small">LGTM!</div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif;font-size:small"><br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif;font-size:small">

Thanks,</div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif;font-size:small">-Jiangning</div></div><div class="gmail_extra"><br><br><div class="gmail_quote">2014/1/15 Kevin Qin <span dir="ltr"><<a href="mailto:kevinqindev@gmail.com" target="_blank">kevinqindev@gmail.com</a>></span><br>

<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div class="h5">  Fixed a bug in isKnownShuffleVector() which may cause assertion problem. Please review.<br>
<br>
<a href="http://llvm-reviews.chandlerc.com/D2542" target="_blank">http://llvm-reviews.chandlerc.com/D2542</a><br>
<br>
CHANGE SINCE LAST DIFF<br>
  <a href="http://llvm-reviews.chandlerc.com/D2542?vs=6428&id=6454#toc" target="_blank">http://llvm-reviews.chandlerc.com/D2542?vs=6428&id=6454#toc</a><br>
<br>
Files:<br>
  lib/Target/AArch64/AArch64ISelLowering.cpp<br>
  lib/Target/AArch64/AArch64ISelLowering.h<br>
  test/CodeGen/AArch64/neon-copy.ll<br>
<br></div></div>_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
<br></blockquote></div><span class="HOEnZb"><font color="#888888"><br><br clear="all"><div><br></div>-- <br><div dir="ltr"><font face="courier new, monospace">Thanks,</font><div><font face="courier new, monospace">-Jiangning</font></div>
</div>
</font></span></div>
<br>_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
<br></blockquote></div><br></div>