<div dir="ltr">Sorry, forgot to add the files.  Fixed in r199765.</div><div class="gmail_extra"><br><br><div class="gmail_quote">On Fri, Jan 17, 2014 at 9:09 AM, Rafael Espíndola <span dir="ltr"><<a href="mailto:rafael.espindola@gmail.com" target="_blank">rafael.espindola@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">testcase?<br>
<div class="HOEnZb"><div class="h5"><br>
On 5 January 2014 23:39, David Majnemer <<a href="mailto:david.majnemer@gmail.com">david.majnemer@gmail.com</a>> wrote:<br>
> Author: majnemer<br>
> Date: Mon Jan  6 01:39:46 2014<br>
> New Revision: 198590<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=198590&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=198590&view=rev</a><br>
> Log:<br>
> MC: Fatally error if subtraction operand is bad<br>
><br>
> Instead of crashing, raise an error when a subtraction expression<br>
> involves an undefined symbol.<br>
><br>
> This fixes PR18375.<br>
><br>
> Modified:<br>
>     llvm/trunk/lib/MC/ELFObjectWriter.cpp<br>
>     llvm/trunk/lib/MC/WinCOFFObjectWriter.cpp<br>
><br>
> Modified: llvm/trunk/lib/MC/ELFObjectWriter.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/MC/ELFObjectWriter.cpp?rev=198590&r1=198589&r2=198590&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/MC/ELFObjectWriter.cpp?rev=198590&r1=198589&r2=198590&view=diff</a><br>

> ==============================================================================<br>
> --- llvm/trunk/lib/MC/ELFObjectWriter.cpp (original)<br>
> +++ llvm/trunk/lib/MC/ELFObjectWriter.cpp Mon Jan  6 01:39:46 2014<br>
> @@ -720,6 +720,12 @@ void ELFObjectWriter::RecordRelocation(c<br>
>        MCSymbolData &SDB = Asm.getSymbolData(SymbolB);<br>
>        IsPCRel = true;<br>
><br>
> +      if (!SDB.getFragment())<br>
> +        Asm.getContext().FatalError(<br>
> +            Fixup.getLoc(),<br>
> +            Twine("symbol '") + SymbolB.getName() +<br>
> +                "' can not be undefined in a subtraction expression");<br>
> +<br>
>        // Offset of the symbol in the section<br>
>        int64_t a = Layout.getSymbolOffset(&SDB);<br>
><br>
><br>
> Modified: llvm/trunk/lib/MC/WinCOFFObjectWriter.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/MC/WinCOFFObjectWriter.cpp?rev=198590&r1=198589&r2=198590&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/MC/WinCOFFObjectWriter.cpp?rev=198590&r1=198589&r2=198590&view=diff</a><br>

> ==============================================================================<br>
> --- llvm/trunk/lib/MC/WinCOFFObjectWriter.cpp (original)<br>
> +++ llvm/trunk/lib/MC/WinCOFFObjectWriter.cpp Mon Jan  6 01:39:46 2014<br>
> @@ -648,14 +648,25 @@ void WinCOFFObjectWriter::RecordRelocati<br>
><br>
>    COFFSection *coff_section = SectionMap[&SectionData->getSection()];<br>
>    COFFSymbol *coff_symbol = SymbolMap[&A_SD.getSymbol()];<br>
> -  const MCSymbolRefExpr *SymA = Target.getSymA();<br>
>    const MCSymbolRefExpr *SymB = Target.getSymB();<br>
> -  const bool CrossSection = SymB &&<br>
> -    &SymA->getSymbol().getSection() != &SymB->getSymbol().getSection();<br>
> +  bool CrossSection = false;<br>
><br>
> -  if (Target.getSymB()) {<br>
> -    const MCSymbol *B = &Target.getSymB()->getSymbol();<br>
> +  if (SymB) {<br>
> +    const MCSymbol *B = &SymB->getSymbol();<br>
>      MCSymbolData &B_SD = Asm.getSymbolData(*B);<br>
> +    if (!B_SD.getFragment())<br>
> +      Asm.getContext().FatalError(<br>
> +          Fixup.getLoc(),<br>
> +          Twine("symbol '") + B->getName() +<br>
> +              "' can not be undefined in a subtraction expression");<br>
> +<br>
> +    if (!A_SD.getFragment())<br>
> +      Asm.getContext().FatalError(<br>
> +          Fixup.getLoc(),<br>
> +          Twine("symbol '") + Symbol.getName() +<br>
> +              "' can not be undefined in a subtraction expression");<br>
> +<br>
> +    CrossSection = &Symbol.getSection() != &B->getSection();<br>
><br>
>      // Offset of the symbol in the section<br>
>      int64_t a = Layout.getSymbolOffset(&B_SD);<br>
><br>
><br>
> _______________________________________________<br>
> llvm-commits mailing list<br>
> <a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</div></div></blockquote></div><br></div>