<div dir="ltr"><div class="gmail_default" style="font-family:arial,helvetica,sans-serif;font-size:small">Hi Ana,</div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif;font-size:small"><br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif;font-size:small">
Do you want to upstream this fix again?</div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif;font-size:small"><br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif;font-size:small">
Thanks,</div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif;font-size:small">-Jiangning</div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif;font-size:small"><br></div></div>
<div class="gmail_extra"><br><br><div class="gmail_quote">2014/1/15 Rafael Espindola <span dir="ltr"><<a href="mailto:rafael.espindola@gmail.com" target="_blank">rafael.espindola@gmail.com</a>></span><br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Author: rafael<br>
Date: Tue Jan 14 13:24:08 2014<br>
New Revision: 199248<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=199248&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=199248&view=rev</a><br>
Log:<br>
Revert "[AArch64] Added vselect patterns with float and double types"<br>
<br>
This reverts commit r199242.<br>
<br>
It is causing CodeGen/AArch64/neon-bsl.ll to fail.<br>
<br>
Modified:<br>
    llvm/trunk/lib/Target/AArch64/AArch64InstrNEON.td<br>
    llvm/trunk/test/CodeGen/AArch64/neon-bsl.ll<br>
<br>
Modified: llvm/trunk/lib/Target/AArch64/AArch64InstrNEON.td<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/AArch64/AArch64InstrNEON.td?rev=199248&r1=199247&r2=199248&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/AArch64/AArch64InstrNEON.td?rev=199248&r1=199247&r2=199248&view=diff</a><br>

==============================================================================<br>
--- llvm/trunk/lib/Target/AArch64/AArch64InstrNEON.td (original)<br>
+++ llvm/trunk/lib/Target/AArch64/AArch64InstrNEON.td Tue Jan 14 13:24:08 2014<br>
@@ -473,10 +473,6 @@ multiclass Neon_bitwise3V_patterns<SDPat<br>
             (INST16B VPR128:$src, VPR128:$Rn, VPR128:$Rm)>;<br>
   def : Pat<(v2i64 (opnode (v2i64 VPR128:$src), VPR128:$Rn, VPR128:$Rm)),<br>
             (INST16B VPR128:$src, VPR128:$Rn, VPR128:$Rm)>;<br>
-  def : Pat<(v2f64 (opnode (v2i64 VPR128:$src), VPR128:$Rn, VPR128:$Rm)),<br>
-            (INST16B VPR128:$src, VPR128:$Rn, VPR128:$Rm)>;<br>
-  def : Pat<(v4f32 (opnode (v4i32 VPR128:$src), VPR128:$Rn, VPR128:$Rm)),<br>
-            (INST16B VPR128:$src, VPR128:$Rn, VPR128:$Rm)>;<br>
<br>
   // Allow to match BSL instruction pattern with non-constant operand<br>
   def : Pat<(v8i8 (or (and VPR64:$Rn, VPR64:$Rd),<br>
<br>
Modified: llvm/trunk/test/CodeGen/AArch64/neon-bsl.ll<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/AArch64/neon-bsl.ll?rev=199248&r1=199247&r2=199248&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/AArch64/neon-bsl.ll?rev=199248&r1=199247&r2=199248&view=diff</a><br>

==============================================================================<br>
--- llvm/trunk/test/CodeGen/AArch64/neon-bsl.ll (original)<br>
+++ llvm/trunk/test/CodeGen/AArch64/neon-bsl.ll Tue Jan 14 13:24:08 2014<br>
@@ -220,14 +220,3 @@ entry:<br>
   ret <2 x double> %vbsl3.i<br>
 }<br>
<br>
-define <2 x double> @bsl2xf64(<2 x i1> %v1, <2 x double> %v2, <2 x double> %v3) {<br>
-;CHECK: bsl {{v[0-9]+}}.16b, {{v[0-9]+}}.16b, {{v[0-9]+}}.16b<br>
-  %1 = select <2 x i1> %v1, <2 x double> %v2, <2 x double> %v3<br>
-  ret <2 x double> %1<br>
-}<br>
-<br>
-define <4 x float> @bsl4xf32(<4 x i1> %v1, <4 x float> %v2, <4 x float> %v3) {<br>
-;CHECK: bsl {{v[0-9]+}}.16b, {{v[0-9]+}}.16b, {{v[0-9]+}}.16b<br>
-  %1 = select <4 x i1> %v1, <4 x float> %v2, <4 x float> %v3<br>
-  ret <4 x float> %1<br>
-}<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div dir="ltr"><font face="courier new, monospace">Thanks,</font><div><font face="courier new, monospace">-Jiangning</font></div></div>
</div>