<div dir="ltr">Could you put the `llvm::BumpPtrAllocator alloc;` in the test fixture to reduce the boilerplate in these test cases? If possible, removing the `alloc` argument from the calls to parse() (or defaulting to the allocator in the fixture) would also clean things up.<div>
<br></div><div>-- Sean Silva</div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Mon, Jan 13, 2014 at 6:02 PM, Rui Ueyama <span dir="ltr"><<a href="mailto:ruiu@google.com" target="_blank">ruiu@google.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: ruiu<br>
Date: Mon Jan 13 17:02:03 2014<br>
New Revision: 199161<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=199161&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=199161&view=rev</a><br>
Log:<br>
Use bettter names for the tests.<br>
<br>
Modified:<br>
    lld/trunk/unittests/DriverTests/WinLinkModuleDefTest.cpp<br>
<br>
Modified: lld/trunk/unittests/DriverTests/WinLinkModuleDefTest.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/unittests/DriverTests/WinLinkModuleDefTest.cpp?rev=199161&r1=199160&r2=199161&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/lld/trunk/unittests/DriverTests/WinLinkModuleDefTest.cpp?rev=199161&r1=199160&r2=199161&view=diff</a><br>

==============================================================================<br>
--- lld/trunk/unittests/DriverTests/WinLinkModuleDefTest.cpp (original)<br>
+++ lld/trunk/unittests/DriverTests/WinLinkModuleDefTest.cpp Mon Jan 13 17:02:03 2014<br>
@@ -68,7 +68,7 @@ TEST_F(ParserTest, Exports) {<br>
   EXPECT_EQ(exports[4].isData, true);<br>
 }<br>
<br>
-TEST_F(ParserTest, Heapsize1) {<br>
+TEST_F(ParserTest, Heapsize) {<br>
   llvm::BumpPtrAllocator alloc;<br>
   llvm::Optional<moduledef::Directive *> dir = parse("HEAPSIZE 65536", alloc);<br>
   EXPECT_TRUE(dir.hasValue());<br>
@@ -78,7 +78,7 @@ TEST_F(ParserTest, Heapsize1) {<br>
   EXPECT_EQ(0U, heapsize->getCommit());<br>
 }<br>
<br>
-TEST_F(ParserTest, Heapsize2) {<br>
+TEST_F(ParserTest, Heapsize_WithCommit) {<br>
   llvm::BumpPtrAllocator alloc;<br>
   llvm::Optional<moduledef::Directive *> dir = parse("HEAPSIZE 65536, 8192", alloc);<br>
   EXPECT_TRUE(dir.hasValue());<br>
@@ -88,7 +88,7 @@ TEST_F(ParserTest, Heapsize2) {<br>
   EXPECT_EQ(8192U, heapsize->getCommit());<br>
 }<br>
<br>
-TEST_F(ParserTest, Name1) {<br>
+TEST_F(ParserTest, Name) {<br>
   llvm::BumpPtrAllocator alloc;<br>
   llvm::Optional<moduledef::Directive *> dir = parse("NAME foo.exe", alloc);<br>
   EXPECT_TRUE(dir.hasValue());<br>
@@ -98,7 +98,7 @@ TEST_F(ParserTest, Name1) {<br>
   EXPECT_EQ(0U, name->getBaseAddress());<br>
 }<br>
<br>
-TEST_F(ParserTest, Name2) {<br>
+TEST_F(ParserTest, Name_WithBase) {<br>
   llvm::BumpPtrAllocator alloc;<br>
   llvm::Optional<moduledef::Directive *> dir = parse("NAME foo.exe BASE=4096", alloc);<br>
   EXPECT_TRUE(dir.hasValue());<br>
@@ -108,7 +108,7 @@ TEST_F(ParserTest, Name2) {<br>
   EXPECT_EQ(4096U, name->getBaseAddress());<br>
 }<br>
<br>
-TEST_F(ParserTest, Name3) {<br>
+TEST_F(ParserTest, Name_LongFileName) {<br>
   llvm::BumpPtrAllocator alloc;<br>
   llvm::Optional<moduledef::Directive *> dir = parse(<br>
       "NAME \"a long file name.exe\"", alloc);<br>
@@ -119,7 +119,7 @@ TEST_F(ParserTest, Name3) {<br>
   EXPECT_EQ(0U, name->getBaseAddress());<br>
 }<br>
<br>
-TEST_F(ParserTest, Version1) {<br>
+TEST_F(ParserTest, Version_Major) {<br>
   llvm::BumpPtrAllocator alloc;<br>
   llvm::Optional<moduledef::Directive *> dir = parse("VERSION 12", alloc);<br>
   EXPECT_TRUE(dir.hasValue());<br>
@@ -129,7 +129,7 @@ TEST_F(ParserTest, Version1) {<br>
   EXPECT_EQ(0, ver->getMinorVersion());<br>
 }<br>
<br>
-TEST_F(ParserTest, Version2) {<br>
+TEST_F(ParserTest, Version_MajorMinor) {<br>
   llvm::BumpPtrAllocator alloc;<br>
   llvm::Optional<moduledef::Directive *> dir = parse("VERSION 12.34", alloc);<br>
   EXPECT_TRUE(dir.hasValue());<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div>