<div dir="ltr">So assertion failures on Windows are no longer printed as wide strings?  If so, thanks for fixing this!</div><div class="gmail_extra"><br><br><div class="gmail_quote">On Sun, Jan 12, 2014 at 8:14 AM, NAKAMURA Takumi <span dir="ltr"><<a href="mailto:geek4civic@gmail.com" target="_blank">geek4civic@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: chapuni<br>
Date: Sun Jan 12 10:14:24 2014<br>
New Revision: 199057<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=199057&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=199057&view=rev</a><br>
Log:<br>
raw_fd_ostream: Don't change STDERR to O_BINARY, or w*printf() (in assert()) would barf wide chars after llvm::errs().<br>
<br>
Modified:<br>
    llvm/trunk/lib/Support/raw_ostream.cpp<br>
<br>
Modified: llvm/trunk/lib/Support/raw_ostream.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Support/raw_ostream.cpp?rev=199057&r1=199056&r2=199057&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Support/raw_ostream.cpp?rev=199057&r1=199056&r2=199057&view=diff</a><br>

==============================================================================<br>
--- llvm/trunk/lib/Support/raw_ostream.cpp (original)<br>
+++ llvm/trunk/lib/Support/raw_ostream.cpp Sun Jan 12 10:14:24 2014<br>
@@ -469,9 +469,10 @@ raw_fd_ostream::raw_fd_ostream(int fd, b<br>
   : raw_ostream(unbuffered), FD(fd),<br>
     ShouldClose(shouldClose), Error(false), UseAtomicWrites(false) {<br>
 #ifdef O_BINARY<br>
-  // Setting STDOUT and STDERR to binary mode is necessary in Win32<br>
+  // Setting STDOUT to binary mode is necessary in Win32<br>
   // to avoid undesirable linefeed conversion.<br>
-  if (fd == STDOUT_FILENO || fd == STDERR_FILENO)<br>
+  // Don't touch STDERR, or w*printf() (in assert()) would barf wide chars.<br>
+  if (fd == STDOUT_FILENO)<br>
     setmode(fd, O_BINARY);<br>
 #endif<br>
<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div>