<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On 9 January 2014 19:29, Alp Toker <span dir="ltr"><<a href="mailto:alp@nuanti.com" target="_blank">alp@nuanti.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
Drive-by comment: Can you move all the rc asserts into a single check within ReadBytes()?<br>
<br>
They seem to check the same thing -- that the requested number of bytes was actually read.</blockquote><div></div></div><br></div><div class="gmail_extra">Just realise I can't do that, because handleLoadSection doesn't assert on bad message, but return LLI_Status_IncompleteMsg to the caller, as I think it should, since in that case, assert would be too hard failure, the caller might want to try again in the future.</div>
<div class="gmail_extra"><br></div><div class="gmail_extra">Since that file is going to die soon, I'd rather leave hard choices for a different commit.</div><div class="gmail_extra"><br></div><div class="gmail_extra">
cheers,</div><div class="gmail_extra">--renato</div></div>