Ah right. Fair enough. For some reason I thought you guys did windows hosted stuff on occasion. I don't know what made me think that.<div><br></div><div>-eric<br><br><div>On Fri Jan 10 2014 at 3:34:51 PM, Robinson, Paul <<a href="mailto:Paul_Robinson@playstation.sony.com">Paul_Robinson@playstation.sony.com</a>> wrote:</div>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div lang="EN-US" link="blue" vlink="purple">
<div>
<p><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">We’re Windows hosted but not Windows targeted, so didn’t seem relevant to our stuff.<u></u><u></u></span></p>
<p><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">If “this” was about something else let me know; I haven’t been paying attention to this thread.<u></u><u></u></span></p>
<p><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">--paulr<u></u><u></u></span></p>
<p><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"><u></u> <u></u></span></p>
<div style="border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt">
<div>
<div style="border:none;border-top:solid #b5c4df 1.0pt;padding:3.0pt 0in 0in 0in">
<p><b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">From:</span></b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif""> Eric Christopher [mailto:<a href="mailto:echristo@gmail.com" target="_blank">echristo@gmail.com</a>]
<br>
<b>Sent:</b> Friday, January 10, 2014 12:50 PM<br>
<b>To:</b> <a href="mailto:timurrrr@google.com" target="_blank">timurrrr@google.com</a>; <a href="mailto:reviews%2BD2232%2Bpublic%2B3e8da1453c292d84@llvm-reviews.chandlerc.com" target="_blank">reviews+D2232+public+3e8da1453c292d84@llvm-reviews.chandlerc.com</a>; <a href="mailto:rnk@google.com" target="_blank">rnk@google.com</a>; <a href="mailto:dblaikie@gmail.com" target="_blank">dblaikie@gmail.com</a>; <a href="mailto:william.ledoux@gmail.com" target="_blank">william.ledoux@gmail.com</a>; <a href="mailto:rafael.espindola@gmail.com" target="_blank">rafael.espindola@gmail.com</a>; <a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a>; Robinson, Paul<br>
<b>Subject:</b> Re: [PATCH] [prototype] Adding line table debug information to LLVM on Windows<u></u><u></u></span></p>
</div>
</div></div></div></div><div lang="EN-US" link="blue" vlink="purple"><div><div style="border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt">
<p><u></u> <u></u></p>
<p>Paul: Is this going to be an issue for you guys? I imagine so, but I'd like to verify.<u></u><u></u></p>
<div>
<p><u></u> <u></u></p>
</div>
<div>
<p style="margin-bottom:12.0pt">-eric<u></u><u></u></p>
<div>
<p>On Fri Jan 10 2014 at 5:30:15 AM, Timur Iskhodzhanov <<a href="mailto:timurrrr@google.com" target="_blank">timurrrr@google.com</a>> wrote:<u></u><u></u></p>
</div>
<blockquote style="border:none;border-left:solid #cccccc 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-right:0in">
<p>As we've discussed on llvm-dev earlier, we'll choose the debug info format based on the triple for now (to simplify things) but may add a command line option later when needed.<u></u><u></u></p>
<p>Are you OK if I just add a FIXME before the condition for now?<u></u><u></u></p>
<div>
<p>09 янв. 2014 г. 18:11 пользователь "Eric Christopher" <<a href="mailto:echristo@gmail.com" target="_blank">echristo@gmail.com</a>> написал:<u></u><u></u></p>
</div>
<div>
<blockquote style="border:none;border-left:solid #cccccc 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-right:0in">
<p><u></u> <u></u></p>
<p><br>
Looks pretty good, thanks.<br>
<br>
I'd prefer you split out the MC bit when you commit, just because it's not necessary as part of this. One other comment below.<br>
<br>
<br>
================<br>
Comment at: lib/CodeGen/AsmPrinter/AsmPrinter.cpp:198<br>
@@ -195,3 +197,3 @@<br>
if (MAI->doesSupportDebugInformation()) {<br>
- DD = new DwarfDebug(this, &M);<br>
- Handlers.push_back(HandlerInfo(DD, DbgTimerName, DWARFGroupName));<br>
+ if (Triple(TM.getTargetTriple()).isOSWindows()) {<br>
+ Handlers.push_back(HandlerInfo(new WinCodeViewLineTables(this),<br>
----------------<br>
I'm not sure this is the right conditional for this - at the very least it should be possible to continue with dwarf information on windows and this isn't going to let it. Possibly a command line option?<br>
<br>
<br>
<a href="http://llvm-reviews.chandlerc.com/D2232" target="_blank">http://llvm-reviews.chandlerc.com/D2232</a><u></u><u></u></p>
</blockquote>
</div>
</blockquote>
</div>
</div></div></div></blockquote></div>