<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=koi8-r">
<meta name="Generator" content="Microsoft Word 14 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Tahoma;
panose-1:2 11 6 4 3 5 4 4 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman","serif";}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
p
{mso-style-priority:99;
mso-margin-top-alt:auto;
margin-right:0in;
mso-margin-bottom-alt:auto;
margin-left:0in;
font-size:12.0pt;
font-family:"Times New Roman","serif";}
span.EmailStyle18
{mso-style-type:personal-reply;
font-family:"Calibri","sans-serif";
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri","sans-serif";}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="blue" vlink="purple">
<div class="WordSection1">
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">We’re Windows hosted but not Windows targeted, so didn’t seem relevant to our stuff.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">If “this” was about something else let me know; I haven’t been paying attention to this thread.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">--paulr<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></p>
<div style="border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt">
<div>
<div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">From:</span></b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif""> Eric Christopher [mailto:echristo@gmail.com]
<br>
<b>Sent:</b> Friday, January 10, 2014 12:50 PM<br>
<b>To:</b> timurrrr@google.com; reviews+D2232+public+3e8da1453c292d84@llvm-reviews.chandlerc.com; rnk@google.com; dblaikie@gmail.com; william.ledoux@gmail.com; rafael.espindola@gmail.com; llvm-commits@cs.uiuc.edu; Robinson, Paul<br>
<b>Subject:</b> Re: [PATCH] [prototype] Adding line table debug information to LLVM on Windows<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Paul: Is this going to be an issue for you guys? I imagine so, but I'd like to verify.<o:p></o:p></p>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-bottom:12.0pt">-eric<o:p></o:p></p>
<div>
<p class="MsoNormal">On Fri Jan 10 2014 at 5:30:15 AM, Timur Iskhodzhanov <<a href="mailto:timurrrr@google.com">timurrrr@google.com</a>> wrote:<o:p></o:p></p>
</div>
<blockquote style="border:none;border-left:solid #CCCCCC 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-right:0in">
<p>As we've discussed on llvm-dev earlier, we'll choose the debug info format based on the triple for now (to simplify things) but may add a command line option later when needed.<o:p></o:p></p>
<p>Are you OK if I just add a FIXME before the condition for now?<o:p></o:p></p>
<div>
<p class="MsoNormal">09 янв. 2014 г. 18:11 пользователь "Eric Christopher" <<a href="mailto:echristo@gmail.com" target="_blank">echristo@gmail.com</a>> написал:<o:p></o:p></p>
</div>
<div>
<blockquote style="border:none;border-left:solid #CCCCCC 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-right:0in">
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><br>
Looks pretty good, thanks.<br>
<br>
I'd prefer you split out the MC bit when you commit, just because it's not necessary as part of this. One other comment below.<br>
<br>
<br>
================<br>
Comment at: lib/CodeGen/AsmPrinter/AsmPrinter.cpp:198<br>
@@ -195,3 +197,3 @@<br>
if (MAI->doesSupportDebugInformation()) {<br>
- DD = new DwarfDebug(this, &M);<br>
- Handlers.push_back(HandlerInfo(DD, DbgTimerName, DWARFGroupName));<br>
+ if (Triple(TM.getTargetTriple()).isOSWindows()) {<br>
+ Handlers.push_back(HandlerInfo(new WinCodeViewLineTables(this),<br>
----------------<br>
I'm not sure this is the right conditional for this - at the very least it should be possible to continue with dwarf information on windows and this isn't going to let it. Possibly a command line option?<br>
<br>
<br>
<a href="http://llvm-reviews.chandlerc.com/D2232" target="_blank">http://llvm-reviews.chandlerc.com/D2232</a><o:p></o:p></p>
</blockquote>
</div>
</blockquote>
</div>
</div>
</div>
</body>
</html>