<html><head><meta http-equiv="Content-Type" content="text/html charset=windows-1252"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><br><div><div>On Jan 4, 2014, at 11:43 AM, Joey Gouly <<a href="mailto:joey.gouly@gmail.com">joey.gouly@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div dir="ltr">Does something like this look good?<div><br></div><div>Now I get:</div><div><div>../projects/lld/lib/ReaderWriter/MachO/MachONormalizedFileYAML.cpp:247:47: warning: 'N_PBUD' is deprecated [-Wdeprecated-declarations]</div>
<div> io.enumCase(value, "N_PBUD", llvm::MachO::N_PBUD);</div><div> ^</div><div>../include/llvm/Support/MachO.h:302:7: note: 'N_PBUD' declared here</div><div>
N_PBUD LLVM_DEPRECATED = 0xcu,</div><div> ^</div><div>../projects/lld/lib/ReaderWriter/MachO/MachONormalizedFileYAML.cpp:248:47: warning: 'N_INDR' is deprecated [-Wdeprecated-declarations]</div><div> io.enumCase(value, "N_INDR", llvm::MachO::N_INDR);</div>
<div> ^</div><div>../include/llvm/Support/MachO.h:303:7: note: 'N_INDR' declared here</div><div> N_INDR LLVM_DEPRECATED = 0xau</div><div> ^</div><div>2 warnings generated.</div>
</div><div><br></div><div><br></div><div>But do we not want to support these at all? Surely someone *could* use lld with something that does contain N_PBUD or N_INR?</div></div></blockquote><div>N_PBUD was only used on PowerPC binaries that were prebound. I can’t imagine anyone wanting a yaml version of those old bits.</div><div><br></div><div>We have enough work to do just getting modern mach-o linking with lld. I don’t want to spend cycles worrying about older mach-o variants.</div><div><br></div><div>-Nick</div><div><br></div><br><blockquote type="cite"><div class="gmail_extra"><br><br><div class="gmail_quote">
On 4 January 2014 01:59, Nick Kledzik <span dir="ltr"><<a href="mailto:kledzik@apple.com" target="_blank">kledzik@apple.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div style="word-wrap:break-word"><br><div><div class="im"><div>On Jan 3, 2014, at 5:50 PM, Joey Gouly <<a href="mailto:joey.gouly@gmail.com" target="_blank">joey.gouly@gmail.com</a>> wrote:</div><br><blockquote type="cite">
<div dir="ltr">Weird, I'm sure I added it because I was hitting it in some tests, but re-running those, and it looks like I'm not.<div><br></div><div>Shall we revert this? (If I hit those again, I'll look closer)</div>
</div></blockquote></div><div>Is there a way to mark the underlying constants deprecated or obsolete in llvm/Support/MachO.h? I’d like to clean up the MachO.h file that way. Then you could not accidentally use them in lld.</div>
<span class="HOEnZb"><font color="#888888"><div><br></div><div>-Nick</div></font></span><div class="im"><div><br></div><br><blockquote type="cite"><div dir="ltr">
</div><div class="gmail_extra"><br><br><div class="gmail_quote">On 4 January 2014 01:38, Nick Kledzik <span dir="ltr"><<a href="mailto:kledzik@apple.com" target="_blank">kledzik@apple.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div><br>
On Jan 3, 2014, at 5:22 PM, Joey Gouly <<a href="mailto:joey.gouly@gmail.com" target="_blank">joey.gouly@gmail.com</a>> wrote:<br>
> Author: joey<br>
> Date: Fri Jan 3 19:22:05 2014<br>
> New Revision: 198468<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=198468&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=198468&view=rev</a><br>
> Log:<br>
> [MachO] Add some missing NListTypes.<br>
><br>
> Modified:<br>
> lld/trunk/lib/ReaderWriter/MachO/MachONormalizedFileYAML.cpp<br>
><br>
> Modified: lld/trunk/lib/ReaderWriter/MachO/MachONormalizedFileYAML.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/MachO/MachONormalizedFileYAML.cpp?rev=198468&r1=198467&r2=198468&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/MachO/MachONormalizedFileYAML.cpp?rev=198468&r1=198467&r2=198468&view=diff</a><br>
> ==============================================================================<br>
> --- lld/trunk/lib/ReaderWriter/MachO/MachONormalizedFileYAML.cpp (original)<br>
> +++ lld/trunk/lib/ReaderWriter/MachO/MachONormalizedFileYAML.cpp Fri Jan 3 19:22:05 2014<br>
> @@ -244,6 +244,8 @@ struct ScalarEnumerationTraits<NListType<br>
> io.enumCase(value, "N_UNDF", llvm::MachO::N_UNDF);<br>
> io.enumCase(value, "N_ABS", llvm::MachO::N_ABS);<br>
> io.enumCase(value, "N_SECT", llvm::MachO::N_SECT);<br>
> + io.enumCase(value, "N_PBUD", llvm::MachO::N_PBUD);<br>
</div>N_PUBD is obsolete and has not been used for 5+ years.<br>
<div><br>
<br>
> + io.enumCase(value, "N_INDR", llvm::MachO::N_INDR);<br>
</div>This too is no longer used, but I have a bug that there is a case for bringing it back.<br>
<span><font color="#888888"><br>
-Nick<br>
<br>
<br>
<br>
<br>
</font></span></blockquote></div><br></div>
</blockquote></div></div><br></div></blockquote></div><br></div>
<span><deprecated_enums.diff></span></blockquote></div><br></body></html>