<div dir="ltr">Thank you for reviewing. Done in r198642.</div><div class="gmail_extra"><br><br><div class="gmail_quote">On Mon, Jan 6, 2014 at 2:40 PM, Nick Kledzik <span dir="ltr"><<a href="mailto:kledzik@apple.com" target="_blank">kledzik@apple.com</a>></span> wrote:<br>

<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="HOEnZb"><div class="h5"><br>
On Jan 6, 2014, at 2:31 PM, Rui Ueyama <<a href="mailto:ruiu@google.com">ruiu@google.com</a>> wrote:<br>
> Author: ruiu<br>
> Date: Mon Jan  6 16:31:01 2014<br>
> New Revision: 198641<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=198641&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=198641&view=rev</a><br>
> Log:<br>
> Rename parameters to fix shadow warnings.<br>
><br>
> Modified:<br>
>    lld/trunk/lib/ReaderWriter/PECOFF/EdataPass.h<br>
><br>
> Modified: lld/trunk/lib/ReaderWriter/PECOFF/EdataPass.h<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/PECOFF/EdataPass.h?rev=198641&r1=198640&r2=198641&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/PECOFF/EdataPass.h?rev=198641&r1=198640&r2=198641&view=diff</a><br>


> ==============================================================================<br>
> --- lld/trunk/lib/ReaderWriter/PECOFF/EdataPass.h (original)<br>
> +++ lld/trunk/lib/ReaderWriter/PECOFF/EdataPass.h Mon Jan  6 16:31:01 2014<br>
> @@ -36,9 +36,10 @@ namespace pecoff {<br>
> namespace edata {<br>
><br>
> struct TableEntry {<br>
> -  TableEntry(StringRef exportName, int ordinal, const DefinedAtom *atom,<br>
> -             bool noname)<br>
> -      : exportName(exportName), ordinal(ordinal), atom(atom), noname(noname) {}<br>
> +  TableEntry(StringRef _exportName, int _ordinal, const DefinedAtom *_atom,<br>
> +             bool _noname)<br>
> +      : exportName(_exportName), ordinal(_ordinal), atom(_atom),<br>
> +        noname(_noname) {}<br>
>   StringRef exportName;<br>
>   int ordinal;<br>
>   const DefinedAtom *atom;<br>
<br>
</div></div>Thanks for fixing the warning, but please use different names for the parameters.  The leading underscore makes them look like instance variables.  The exact opposite of what is going on.<br>
<span class="HOEnZb"><font color="#888888"><br>
-Nick<br>
<br>
<br>
</font></span></blockquote></div><br></div>