<br><br><div>On Tue Dec 31 2013 at 11:03:34 PM, Alp Toker <<a href="mailto:alp@nuanti.com">alp@nuanti.com</a>> wrote:</div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Author: alp<br>
Date: Wed Jan  1 00:57:01 2014<br>
New Revision: 198273<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=198273&view=rev" target="_blank">http://llvm.org/viewvc/llvm-<u></u>project?rev=198273&view=rev</a><br>
Log:<br>
Silence g++ 4.9 build issue in unit tests<br>
<br>
Stopgap measure until we can just use static_assert().<br>
<br>
Modified:<br>
    llvm/trunk/unittests/IR/<u></u>ValueMapTest.cpp<br>
<br>
Modified: llvm/trunk/unittests/IR/<u></u>ValueMapTest.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/unittests/IR/ValueMapTest.cpp?rev=198273&r1=198272&r2=198273&view=diff" target="_blank">http://llvm.org/viewvc/llvm-<u></u>project/llvm/trunk/unittests/<u></u>IR/ValueMapTest.cpp?rev=<u></u>198273&r1=198272&r2=198273&<u></u>view=diff</a><br>

==============================<u></u>==============================<u></u>==================<br>
--- llvm/trunk/unittests/IR/<u></u>ValueMapTest.cpp (original)<br>
+++ llvm/trunk/unittests/IR/<u></u>ValueMapTest.cpp Wed Jan  1 00:57:01 2014<br>
@@ -117,7 +117,8 @@ TYPED_TEST(ValueMapTest, OperationsWork)<br>
<br>
 template<typename ExpectedType, typename VarType><br>
 void CompileAssertHasType(VarType) {<br>
-  typedef char assert[is_same<ExpectedType, VarType>::value ? 1 : -1];<br>
+  LLVM_ATTRIBUTE_UNUSED typedef char<br>
+  assert[is_same<ExpectedType, VarType>::value ? 1 : -1];<br></blockquote><div><br></div><div>Naming something 'assert' which is a standard macro (even if the standard header that defines it is not included) seems questionable.<br>
<br>& is there a reason we're not using the LLVM_STATIC_ASSERT macro here?</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
 }<br>
<br>
 TYPED_TEST(ValueMapTest, Iteration) {<br>
<br>
<br>
______________________________<u></u>_________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/<u></u>mailman/listinfo/llvm-commits</a><br>
</blockquote>