<div dir="ltr"><div class="gmail_default" style="font-family:arial,helvetica,sans-serif;font-size:small">Hao,</div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif;font-size:small"><br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif;font-size:small">
The patch LGTM now, and could you please add "//FIXME: we should NOT generate ld/st for register spill/fill" in the test case before upstream?</div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif;font-size:small">
<br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif;font-size:small">Thanks,</div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif;font-size:small">-Jiangning</div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif;font-size:small">
<br></div></div><div class="gmail_extra"><br><br><div class="gmail_quote">2013/12/27 Hao Liu <span dir="ltr"><<a href="mailto:Hao.Liu@arm.com" target="_blank">Hao.Liu@arm.com</a>></span><br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
  Hi Jiangning,<br>
<br>
  Thanks for the review.<br>
  I simplify the code according to your comments. And I find that the spill of DPair/DTriple/DQuad registers are always translated into QPair/QTriple/QQuad in loadRegFromStackSlot/storeRegToStackSlot according to the attached test cases. I think this is caused by the one by one correspondence that a D register is always the low 64-bit of a Q register. I think there is no need to add load/store of 8B, so I remove the LD1x2_8B,LD1x3_8B,LD1x4_8B....ST1x4_8B. If there is such situation to spill D register tuples in the future, we can add code according to the code of spill Q register tuples.<br>

<br>
  Thanks,<br>
  -Hao<br>
<br>
Hi t.p.northover,<br>
<br>
<a href="http://llvm-reviews.chandlerc.com/D2438" target="_blank">http://llvm-reviews.chandlerc.com/D2438</a><br>
<br>
CHANGE SINCE LAST DIFF<br>
  <a href="http://llvm-reviews.chandlerc.com/D2438?vs=6178&id=6279#toc" target="_blank">http://llvm-reviews.chandlerc.com/D2438?vs=6178&id=6279#toc</a><br>
<br>
Files:<br>
  lib/Target/AArch64/AArch64InstrInfo.cpp<br>
  lib/Target/AArch64/AArch64RegisterInfo.cpp<br>
  test/CodeGen/AArch64/neon-vector-list-spill.ll<br>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div dir="ltr"><font face="courier new, monospace">Thanks,</font><div><font face="courier new, monospace">-Jiangning</font></div></div>
</div>