<div dir="ltr">LGTM, committed in r198056.</div><div class="gmail_extra"><br><br><div class="gmail_quote">On Tue, Dec 24, 2013 at 5:47 AM, Brad Smith <span dir="ltr"><<a href="mailto:brad@comstyle.com" target="_blank">brad@comstyle.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="im">On 20/12/13 6:22 AM, Brad Smith wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
On 16/12/13 5:06 AM, Brad Smith wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
I noticed this commit...<br>
<br>
Author: joerg<br>
Date: Sun Dec 15 14:36:17 2013<br>
New Revision: 197348<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=197348&view=rev" target="_blank">http://llvm.org/viewvc/llvm-<u></u>project?rev=197348&view=rev</a><br>
Log:<br>
There is no exp10 on NetBSD.<br>
<br>
Modified:<br>
llvm/trunk/lib/Target/<u></u>TargetLibraryInfo.cpp<br>
<br>
and went looking. This needs to be fixed to properly deal with the<br>
relevent<br>
OS's what is targetted. exp10 and family is a GNU extension and as far<br>
as I<br>
can see is only available on Linux and OS X/iOS. So this should be<br>
disabled<br>
by default and only enabled on OS's that are known to have the exp10<br>
family<br>
of functions.<br>
</blockquote>
<br>
ping.<br>
</blockquote>
<br></div>
... still broken.<div class="HOEnZb"><div class="h5"><br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Index: lib/Target/TargetLibraryInfo.<u></u>cpp<br>
==============================<u></u>==============================<u></u>=======<br>
--- lib/Target/TargetLibraryInfo.<u></u>cpp (revision 197364)<br>
+++ lib/Target/TargetLibraryInfo.<u></u>cpp (working copy)<br>
@@ -401,37 +401,6 @@<br>
TLI.setAvailableWithName(<u></u>LibFunc::fputs, "fputs$UNIX2003");<br>
}<br>
<br>
- // exp10 and exp10f are not available on OS X until 10.9 and iOS<br>
until 7.0<br>
- // and their names are __exp10 and __exp10f. exp10l is not<br>
available on<br>
- // OS X or iOS.<br>
- if (T.isMacOSX()) {<br>
- TLI.setUnavailable(LibFunc::<u></u>exp10l);<br>
- if (T.isMacOSXVersionLT(10, 9)) {<br>
- TLI.setUnavailable(LibFunc::<u></u>exp10);<br>
- TLI.setUnavailable(LibFunc::<u></u>exp10f);<br>
- } else {<br>
- TLI.setAvailableWithName(<u></u>LibFunc::exp10, "__exp10");<br>
- TLI.setAvailableWithName(<u></u>LibFunc::exp10f, "__exp10f");<br>
- }<br>
- }<br>
-<br>
- if (T.getOS() == Triple::IOS) {<br>
- TLI.setUnavailable(LibFunc::<u></u>exp10l);<br>
- if (T.isOSVersionLT(7, 0)) {<br>
- TLI.setUnavailable(LibFunc::<u></u>exp10);<br>
- TLI.setUnavailable(LibFunc::<u></u>exp10f);<br>
- } else {<br>
- TLI.setAvailableWithName(<u></u>LibFunc::exp10, "__exp10");<br>
- TLI.setAvailableWithName(<u></u>LibFunc::exp10f, "__exp10f");<br>
- }<br>
- }<br>
-<br>
- if (T.getOS() == Triple::NetBSD) {<br>
- TLI.setUnavailable(LibFunc::<u></u>exp10l);<br>
- TLI.setUnavailable(LibFunc::<u></u>exp10);<br>
- TLI.setUnavailable(LibFunc::<u></u>exp10f);<br>
- }<br>
-<br>
// iprintf and friends are only available on XCore and TCE.<br>
if (T.getArch() != Triple::xcore && T.getArch() != Triple::tce) {<br>
TLI.setUnavailable(LibFunc::<u></u>iprintf);<br>
@@ -477,9 +446,6 @@<br>
TLI.setUnavailable(LibFunc::<u></u>cbrt);<br>
TLI.setUnavailable(LibFunc::<u></u>cbrtf);<br>
TLI.setUnavailable(LibFunc::<u></u>cbrtl);<br>
- TLI.setUnavailable(LibFunc::<u></u>exp10);<br>
- TLI.setUnavailable(LibFunc::<u></u>exp10f);<br>
- TLI.setUnavailable(LibFunc::<u></u>exp10l);<br>
TLI.setUnavailable(LibFunc::<u></u>exp2);<br>
TLI.setUnavailable(LibFunc::<u></u>exp2f);<br>
TLI.setUnavailable(LibFunc::<u></u>exp2l);<br>
@@ -598,6 +564,39 @@<br>
TLI.setUnavailable(LibFunc::<u></u>llabs);<br>
}<br>
<br>
+ // exp10, exp10f, exp10l is available on at least Linux (GLIBC)<br>
+ // exp10 and exp10f are not available on OS X until 10.9 and iOS<br>
until 7.0<br>
+ // and their names are __exp10 and __exp10f. exp10l is not<br>
available on<br>
+ // OS X or iOS.<br>
+ switch (T.getOS()) {<br>
+ case Triple::Linux:<br>
+ break;<br>
+ case Triple::MacOSX:<br>
+ TLI.setUnavailable(LibFunc::<u></u>exp10l);<br>
+ if (T.isMacOSXVersionLT(10, 9)) {<br>
+ TLI.setUnavailable(LibFunc::<u></u>exp10);<br>
+ TLI.setUnavailable(LibFunc::<u></u>exp10f);<br>
+ } else {<br>
+ TLI.setAvailableWithName(<u></u>LibFunc::exp10, "__exp10");<br>
+ TLI.setAvailableWithName(<u></u>LibFunc::exp10f, "__exp10f");<br>
+ }<br>
+ break;<br>
+ case Triple::IOS:<br>
+ TLI.setUnavailable(LibFunc::<u></u>exp10l);<br>
+ if (T.isOSVersionLT(7, 0)) {<br>
+ TLI.setUnavailable(LibFunc::<u></u>exp10);<br>
+ TLI.setUnavailable(LibFunc::<u></u>exp10f);<br>
+ } else {<br>
+ TLI.setAvailableWithName(<u></u>LibFunc::exp10, "__exp10");<br>
+ TLI.setAvailableWithName(<u></u>LibFunc::exp10f, "__exp10f");<br>
+ }<br>
+ break;<br>
+ default:<br>
+ TLI.setUnavailable(LibFunc::<u></u>exp10);<br>
+ TLI.setUnavailable(LibFunc::<u></u>exp10f);<br>
+ TLI.setUnavailable(LibFunc::<u></u>exp10l);<br>
+ }<br>
+<br>
// ffsl is available on at least Darwin, Mac OS X, iOS, FreeBSD, and<br>
// Linux (GLIBC):<br>
//<br>
<a href="http://developer.apple.com/library/mac/#documentation/Darwin/Reference/ManPages/man3/ffsl.3.html" target="_blank">http://developer.apple.com/<u></u>library/mac/#documentation/<u></u>Darwin/Reference/ManPages/<u></u>man3/ffsl.3.html</a><br>
<br>
<br>
</blockquote>
<br>
<br>
</blockquote>
<br>
<br>
-- <br>
This message has been scanned for viruses and<br>
dangerous content by MailScanner, and is<br>
believed to be clean.<br>
<br>
______________________________<u></u>_________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/<u></u>mailman/listinfo/llvm-commits</a><br>
</div></div></blockquote></div><br></div>