<div dir="ltr"><div class="gmail_default" style="font-family:arial,helvetica,sans-serif;font-size:small">The patch LGTM!<br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif;font-size:small"><br>
</div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif;font-size:small">Thanks,</div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif;font-size:small">-Jiangning</div></div>
<div class="gmail_extra"><br><br><div class="gmail_quote">2013/12/19 Hao Liu <span dir="ltr"><<a href="mailto:Hao.Liu@arm.com" target="_blank">Hao.Liu@arm.com</a>></span><br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Hi t.p.northover,<br>
<br>
Hi Tim and reviewers,<br>
<br>
This patch fixes the problem that we can't select shl/sra/srl nodes. Match shl to USHL instructions. Match sra/srl to NEG and SSHL/USHL instructions (negative shift amounts for SSHL/USHL means right shfit). This solution is the same as ARM backend.<br>

<br>
Code review. Please.<br>
<br>
Thanks,<br>
-Hao<br>
<br>
<a href="http://llvm-reviews.chandlerc.com/D2439" target="_blank">http://llvm-reviews.chandlerc.com/D2439</a><br>
<br>
Files:<br>
  lib/Target/AArch64/AArch64InstrNEON.td<br>
  test/CodeGen/AArch64/neon-shl-ashr-lshr.ll<br>
<br>_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
<br></blockquote></div><br><br clear="all"><div><br></div>-- <br><div dir="ltr"><font face="courier new, monospace">Thanks,</font><div><font face="courier new, monospace">-Jiangning</font></div></div>
</div>