<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On 20 December 2013 20:12, David Peixotto <span dir="ltr"><<a href="mailto:dpeixott@codeaurora.org" target="_blank">dpeixott@codeaurora.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div class="im"><span style="color:rgb(34,34,34)">To make things concrete, I have attached a patch that fixes issue #1 and adds the pre-UAL aliases. It only accepts encoded floats for the fconst aliases.</span></div>
</blockquote><div></div></div><br></div><div class="gmail_extra">Hi David,</div><div class="gmail_extra"><br></div><div class="gmail_extra">The patch looks good to me, and it doesn't introduce too many changes nor obscure code, so it should be ok to let this in. The tests also look great, thanks!</div>
<div class="gmail_extra"><br></div><div class="gmail_extra">I'd still want Jim to share his opinion, though.</div><div class="gmail_extra"><br></div><div class="gmail_extra">Two specific comments:</div><div class="gmail_extra">
<br></div><div class="gmail_extra"><div class="gmail_extra">-    double RealVal = ARM_AM::getFPImmFloat(Val);</div><div class="gmail_extra">-    Val = APFloat(APFloat::IEEEdouble, RealVal).bitcastToAPInt().getZExtValue();</div>
<div class="gmail_extra">+    float RealVal = ARM_AM::getFPImmFloat(Val);</div><div class="gmail_extra">+    Val = APFloat(RealVal).bitcastToAPInt().getZExtValue();</div><div class="gmail_extra"><br></div><div class="gmail_extra">
Nice catch, you don't need a double.</div><div class="gmail_extra"><br></div><div class="gmail_extra"><div class="gmail_extra">-        Mnemonic == "vfms" || Mnemonic == "vfnms" ||</div><div class="gmail_extra">
+        Mnemonic == "vfms" || Mnemonic == "vfnms" || Mnemonic == "fconsts" ||</div><div class="gmail_extra"><br></div><div class="gmail_extra">Was the fconstd already there?</div><div class="gmail_extra">
<br></div><div class="gmail_extra">cheers,</div><div class="gmail_extra">--renato</div></div></div></div>