<div dir="ltr">Ideally all the relevant manuals for these sorts of changes should be linked from <<a href="http://llvm.org/docs/CompilerWriterInfo.html">http://llvm.org/docs/CompilerWriterInfo.html</a>>. Could you make sure everything is up to date there?<div>
<br></div><div>-- Sean Silva</div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Wed, Dec 18, 2013 at 7:21 PM, Rafael Espindola <span dir="ltr"><<a href="mailto:rafael.espindola@gmail.com" target="_blank">rafael.espindola@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: rafael<br>
Date: Wed Dec 18 20:21:16 2013<br>
New Revision: 197646<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=197646&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=197646&view=rev</a><br>
Log:<br>
Add stack alignment information for Sparc.<br>
<br>
This matches the data in clang which was added by Jakob Stoklund Olesen in<br>
r179596.<br>
<br>
Thanks for erikjv on irc for pointing me to the relevant documents:<br>
<a href="http://sparc.com/standards/64.psabi.1.35.ps.Z" target="_blank">http://sparc.com/standards/64.psabi.1.35.ps.Z</a><br>
page 25: Every stack frame must be 16-byte aligned.<br>
<br>
<a href="http://sparc.com/standards/psABI3rd.pdf" target="_blank">http://sparc.com/standards/psABI3rd.pdf</a><br>
page 3-10: Although the architecture requires only word alignment, software convention and the operating system require every stack frame to be doubleword aligned.<br>
<br>
I tried to add a test, but it looks like sparc doesn't implement dynamic stack<br>
realignment. This will be tested in clang shortly.<br>
<br>
Modified:<br>
    llvm/trunk/lib/Target/Sparc/SparcTargetMachine.cpp<br>
<br>
Modified: llvm/trunk/lib/Target/Sparc/SparcTargetMachine.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/Sparc/SparcTargetMachine.cpp?rev=197646&r1=197645&r2=197646&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/Sparc/SparcTargetMachine.cpp?rev=197646&r1=197645&r2=197646&view=diff</a><br>

==============================================================================<br>
--- llvm/trunk/lib/Target/Sparc/SparcTargetMachine.cpp (original)<br>
+++ llvm/trunk/lib/Target/Sparc/SparcTargetMachine.cpp Wed Dec 18 20:21:16 2013<br>
@@ -41,6 +41,11 @@ static std::string computeDataLayout(con<br>
   else<br>
     Ret += "-f128:64-n32";<br>
<br>
+  if (ST.is64Bit())<br>
+    Ret += "-S128";<br>
+  else<br>
+    Ret += "-S64";<br>
+<br>
   return Ret;<br>
 }<br>
<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div>