Why not just have everyone reply to your original commit?<div><br></div><div>-eric<br><br><div>On Wed Dec 18 2013 at 4:49:16 PM, Reed Kotler <<a href="mailto:rkotler@mips.com">rkotler@mips.com</a>> wrote:</div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Author: rkotler<br>
Date: Wed Dec 18 18:43:08 2013<br>
New Revision: 197638<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=197638&view=rev" target="_blank">http://llvm.org/viewvc/llvm-<u></u>project?rev=197638&view=rev</a><br>
Log:<br>
Make cosmetic changes as part of Mips internal post commit review of<br>
patch r196331.<br>
<br>
<br>
Modified:<br>
    llvm/trunk/lib/Target/Mips/<u></u>MipsConstantIslandPass.cpp<br>
<br>
Modified: llvm/trunk/lib/Target/Mips/<u></u>MipsConstantIslandPass.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/Mips/MipsConstantIslandPass.cpp?rev=197638&r1=197637&r2=197638&view=diff" target="_blank">http://llvm.org/viewvc/llvm-<u></u>project/llvm/trunk/lib/Target/<u></u>Mips/MipsConstantIslandPass.<u></u>cpp?rev=197638&r1=197637&r2=<u></u>197638&view=diff</a><br>

==============================<u></u>==============================<u></u>==================<br>
--- llvm/trunk/lib/Target/Mips/<u></u>MipsConstantIslandPass.cpp (original)<br>
+++ llvm/trunk/lib/Target/Mips/<u></u>MipsConstantIslandPass.cpp Wed Dec 18 18:43:08 2013<br>
@@ -1625,7 +1625,7 @@ MipsConstantIslands::<u></u>fixupConditionalBr(<br>
   MachineBasicBlock *MBB = MI->getParent();<br>
   MachineInstr *BMI = &MBB->back();<br>
   bool NeedSplit = (BMI != MI) || !BBHasFallthrough(MBB);<br>
-  unsigned OppositeBranchOpcode=TII-><u></u>getOppositeBranchOpc(Opcode);<br>
+  unsigned OppositeBranchOpcode = TII->getOppositeBranchOpc(<u></u>Opcode);<br>
<br>
   ++NumCBrFixed;<br>
   if (BMI != MI) {<br>
@@ -1674,9 +1674,9 @@ MipsConstantIslands::<u></u>fixupConditionalBr(<br>
     BuildMI(MBB, DebugLoc(), TII->get(OppositeBranchOpcode)<u></u>)<br>
            .addReg(MI->getOperand(0).<u></u>getReg())<br>
            .addMBB(NextBB);<br>
-  }<br>
-  else { BuildMI(MBB, DebugLoc(), TII->get(OppositeBranchOpcode)<u></u>)<br>
-        .addMBB(NextBB);<br>
+  } else {<br>
+    BuildMI(MBB, DebugLoc(), TII->get(OppositeBranchOpcode)<u></u>)<br>
+           .addMBB(NextBB);<br>
   }<br>
   Br.MI = &MBB->back();<br>
   BBInfo[MBB->getNumber()].Size += TII->GetInstSizeInBytes(&MBB-><u></u>back());<br>
<br>
<br>
______________________________<u></u>_________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/<u></u>mailman/listinfo/llvm-commits</a><br>
</blockquote></div>