<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Word 14 (filtered medium)">
<!--[if !mso]><style>v\:* {behavior:url(#default#VML);}
o\:* {behavior:url(#default#VML);}
w\:* {behavior:url(#default#VML);}
.shape {behavior:url(#default#VML);}
</style><![endif]--><style><!--
/* Font Definitions */
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Tahoma;
panose-1:2 11 6 4 3 5 4 4 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman","serif";}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
p.MsoAcetate, li.MsoAcetate, div.MsoAcetate
{mso-style-priority:99;
mso-style-link:"Balloon Text Char";
margin:0cm;
margin-bottom:.0001pt;
font-size:8.0pt;
font-family:"Tahoma","sans-serif";}
span.EmailStyle17
{mso-style-type:personal-reply;
font-family:"Calibri","sans-serif";
color:windowtext;}
span.BalloonTextChar
{mso-style-name:"Balloon Text Char";
mso-style-priority:99;
mso-style-link:"Balloon Text";
font-family:"Tahoma","sans-serif";
mso-fareast-language:EN-GB;}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri","sans-serif";
mso-fareast-language:EN-US;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:72.0pt 72.0pt 72.0pt 72.0pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-GB" link="blue" vlink="purple">
<div class="WordSection1">
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif"">Hi Eric,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif""><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif"">For the sake of completeness I should mention that a few reviews have been taking place in the MIPS BugZilla (because not everyone has a phabricator account yet). The MIPS
BugZilla is publicly visible but it's not an appropriate place to keep the post-commit reviews from LLVM's point of view. For now, I've been copying these reviews into phabricator when they raise an issue.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif""><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif"">If a review ever turns up a bigger issue than style or whitespace, then I intend to make sure a corresponding reply to the commit-email is sent since email is still the primary
system.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif""><o:p> </o:p></span></p>
<div style="border:none;border-left:solid blue 1.5pt;padding:0cm 0cm 0cm 4.0pt">
<div>
<div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal"><b><span lang="EN-US" style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">From:</span></b><span lang="EN-US" style="font-size:10.0pt;font-family:"Tahoma","sans-serif""> llvm-commits-bounces@cs.uiuc.edu [mailto:llvm-commits-bounces@cs.uiuc.edu]
<b>On Behalf Of </b>Eric Christopher<br>
<b>Sent:</b> 19 December 2013 02:20<br>
<b>To:</b> Reed Kotler; llvm-commits@cs.uiuc.edu<br>
<b>Subject:</b> RE: [llvm] r197638 - Make cosmetic changes as part of Mips internal post commit review of<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal" style="margin-bottom:12.0pt"><o:p> </o:p></p>
<div>
<p class="MsoNormal">On Wed Dec 18 2013 at 4:57:26 PM, Reed Kotler <<a href="mailto:Reed.Kotler@imgtec.com">Reed.Kotler@imgtec.com</a>> wrote:<o:p></o:p></p>
</div>
<blockquote style="border:none;border-left:solid #CCCCCC 1.0pt;padding:0cm 0cm 0cm 6.0pt;margin-left:4.8pt;margin-right:0cm">
<div>
<div>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif";color:black">You have to discuss this with Daniel Sanders who is the Mips maintainer and requestor of post commit
<o:p></o:p></span></p>
<div>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif";color:black">reviews.
<o:p></o:p></span></p>
<div>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif";color:black"><o:p> </o:p></span></p>
</div>
</div>
</div>
</div>
</blockquote>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">Not really. I'm discussing it with the person making the commits.<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"> <o:p></o:p></p>
</div>
<blockquote style="border:none;border-left:solid #CCCCCC 1.0pt;padding:0cm 0cm 0cm 6.0pt;margin-left:4.8pt;margin-right:0cm">
<div>
<div>
<div>
<div>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif";color:black">We are using phabricator for the post commit review and there is a bug filed in our local<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif";color:black">bugzilla.<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif";color:black"><o:p> </o:p></span></p>
</div>
</div>
</div>
</div>
</blockquote>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">Ah, that makes sense. From your commit comment you made it sound like he'd sent you a private mail about it.<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">-eric<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"> <o:p></o:p></p>
</div>
<blockquote style="border:none;border-left:solid #CCCCCC 1.0pt;padding:0cm 0cm 0cm 6.0pt;margin-left:4.8pt;margin-right:0cm">
<div>
<div>
<div>
<div>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif";color:black">Perhaps the work flow should be different. It does not matter much to me.<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif";color:black"><o:p> </o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif";color:black">Reed<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif";color:black"><o:p> </o:p></span></p>
</div>
<div>
<div>
<div class="MsoNormal" align="center" style="text-align:center"><span style="color:black">
<hr size="2" width="100%" align="center">
</span></div>
<div>
<p class="MsoNormal" style="margin-bottom:12.0pt"><b><span style="font-family:"Tahoma","sans-serif";color:black">From:</span></b><span style="font-family:"Tahoma","sans-serif";color:black"> Eric Christopher [<a href="mailto:echristo@gmail.com" target="_blank">echristo@gmail.com</a>]<br>
<b>Sent:</b> Wednesday, December 18, 2013 4:50 PM<br>
<b>To:</b> Reed Kotler; <a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">
llvm-commits@cs.uiuc.edu</a><br>
<b>Subject:</b> [llvm] r197638 - Make cosmetic changes as part of Mips internal post commit review of</span><span style="color:black"><o:p></o:p></span></p>
</div>
</div>
</div>
</div>
</div>
</div>
<div>
<div>
<div>
<div>
<div>
<div>
<p class="MsoNormal"><span style="color:black">Why not just have everyone reply to your original commit?
<o:p></o:p></span></p>
<div>
<p class="MsoNormal"><span style="color:black"><o:p> </o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin-bottom:12.0pt"><span style="color:black">-eric<o:p></o:p></span></p>
<div>
<p class="MsoNormal"><span style="color:black">On Wed Dec 18 2013 at 4:49:16 PM, Reed Kotler <<a href="mailto:rkotler@mips.com" target="_blank">rkotler@mips.com</a>> wrote:<o:p></o:p></span></p>
</div>
<blockquote style="border:none;border-left:solid #CCCCCC 1.0pt;padding:0cm 0cm 0cm 6.0pt;margin-left:4.8pt;margin-right:0cm">
<p class="MsoNormal"><span style="color:black">Author: rkotler<br>
Date: Wed Dec 18 18:43:08 2013<br>
New Revision: 197638<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=197638&view=rev" target="_blank">
http://llvm.org/viewvc/llvm-project?rev=197638&view=rev</a><br>
Log:<br>
Make cosmetic changes as part of Mips internal post commit review of<br>
patch r196331.<br>
<br>
<br>
Modified:<br>
llvm/trunk/lib/Target/Mips/MipsConstantIslandPass.cpp<br>
<br>
Modified: llvm/trunk/lib/Target/Mips/MipsConstantIslandPass.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/Mips/MipsConstantIslandPass.cpp?rev=197638&r1=197637&r2=197638&view=diff" target="_blank">
http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/Mips/MipsConstantIslandPass.cpp?rev=197638&r1=197637&r2=197638&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/lib/Target/Mips/MipsConstantIslandPass.cpp (original)<br>
+++ llvm/trunk/lib/Target/Mips/MipsConstantIslandPass.cpp Wed Dec 18 18:43:08 2013<br>
@@ -1625,7 +1625,7 @@ MipsConstantIslands::fixupConditionalBr(<br>
MachineBasicBlock *MBB = MI->getParent();<br>
MachineInstr *BMI = &MBB->back();<br>
bool NeedSplit = (BMI != MI) || !BBHasFallthrough(MBB);<br>
- unsigned OppositeBranchOpcode=TII->getOppositeBranchOpc(Opcode);<br>
+ unsigned OppositeBranchOpcode = TII->getOppositeBranchOpc(Opcode);<br>
<br>
++NumCBrFixed;<br>
if (BMI != MI) {<br>
@@ -1674,9 +1674,9 @@ MipsConstantIslands::fixupConditionalBr(<br>
BuildMI(MBB, DebugLoc(), TII->get(OppositeBranchOpcode))<br>
.addReg(MI->getOperand(0).getReg())<br>
.addMBB(NextBB);<br>
- }<br>
- else { BuildMI(MBB, DebugLoc(), TII->get(OppositeBranchOpcode))<br>
- .addMBB(NextBB);<br>
+ } else {<br>
+ BuildMI(MBB, DebugLoc(), TII->get(OppositeBranchOpcode))<br>
+ .addMBB(NextBB);<br>
}<br>
Br.MI = &MBB->back();<br>
BBInfo[MBB->getNumber()].Size += TII->GetInstSizeInBytes(&MBB->back());<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><o:p></o:p></span></p>
</blockquote>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
<div>
<div>
<div>
<div>
<div>
<div>
<div>
<div>
<table class="MsoNormalTable" border="0" cellspacing="1" cellpadding="0">
<tbody>
<tr>
<td width="20%" style="width:20.0%;padding:.75pt .75pt .75pt .75pt">
<div>
<p class="MsoNormal">English »<o:p></o:p></p>
</div>
</td>
<td width="20%" style="width:20.0%;padding:.75pt .75pt .75pt .75pt">
<p class="MsoNormal">AfrikaansAlbanianArabic ArmenianAzerbaijaniBasque BengaliBelarusian BulgarianCatalanChinese (Simp) Chinese (Trad)Croatian CzechDanish DutchEnglishEsperanto EstonianFilipinoFinnish FrenchGalicianGeorgian GermanGreekGujarati Haitian CreoleHebrewHindi
HungarianIcelandic IndonesianIrishItalian JapaneseKannadaKorean LaoLatinLatvian LithuanianMacedonianMalay MalteseNorwegian PersianPolishPortuguese RomanianRussianSerbian SlovakSlovenian SpanishSwahiliSwedish TamilTeluguThai TurkishUkrainianUrdu VietnameseWelshYiddish<o:p></o:p></p>
</td>
<td width="13%" style="width:13.0%;padding:.75pt .75pt .75pt .75pt">
<p class="MsoNormal" align="center" style="text-align:center"> <o:p></o:p></p>
</td>
<td width="8%" style="width:8.0%;padding:.75pt .75pt .75pt .75pt"></td>
<td width="8%" style="width:8.0%;padding:.75pt .75pt .75pt .75pt"></td>
<td width="8%" style="width:8.0%;padding:.75pt .75pt .75pt .75pt"></td>
<td width="8%" style="width:8.0%;padding:.75pt .75pt .75pt .75pt"></td>
<td width="5%" style="width:5.0%;padding:.75pt .75pt .75pt .75pt"></td>
<td width="8%" style="width:8.0%;padding:.75pt .75pt .75pt .75pt"></td>
</tr>
</tbody>
</table>
</div>
</div>
<div>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif";color:black">Feedback : History : Options<o:p></o:p></span></p>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</blockquote>
</div>
</div>
</body>
</html>