<br><br><div>On Wed Dec 18 2013 at 4:57:26 PM, Reed Kotler <<a href="mailto:Reed.Kotler@imgtec.com">Reed.Kotler@imgtec.com</a>> wrote:</div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div>
<div style="direction:ltr;font-family:Tahoma;color:#000000;font-size:10pt">You have to discuss this with Daniel Sanders who is the Mips maintainer and requestor of post commit
<div>reviews.
<div><br></div></div></div></div></blockquote><div><br></div><div>Not really. I'm discussing it with the person making the commits.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div><div style="direction:ltr;font-family:Tahoma;color:#000000;font-size:10pt"><div><div>
</div>
<div>We are using phabricator for the post commit review and there is a bug filed in our local</div>
<div>bugzilla.</div>
<div><br></div></div></div></div></blockquote><div><br></div><div>Ah, that makes sense. From your commit comment you made it sound like he'd sent you a private mail about it.</div><div><br></div><div>-eric</div><div>
</div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div style="direction:ltr;font-family:Tahoma;color:#000000;font-size:10pt"><div><div>
</div>
<div>Perhaps the work flow should be different. It does not matter much to me.</div>
<div><br>
</div>
<div>Reed</div>
<div><br>
</div>
<div>
<div style="font-family:Times New Roman;color:#000000;font-size:16px">
<hr>
<div style="direction:ltr"><font face="Tahoma" color="#000000"><b>From:</b> Eric Christopher [<a href="mailto:echristo@gmail.com" target="_blank">echristo@gmail.com</a>]<br>
<b>Sent:</b> Wednesday, December 18, 2013 4:50 PM<br>
<b>To:</b> Reed Kotler; <a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
<b>Subject:</b> [llvm] r197638 - Make cosmetic changes as part of Mips internal post commit review of<br>
</font><br>
</div></div></div></div></div></div><div><div style="direction:ltr;font-family:Tahoma;color:#000000;font-size:10pt"><div><div><div style="font-family:Times New Roman;color:#000000;font-size:16px">
<div></div>
<div>Why not just have everyone reply to your original commit?
<div><br>
</div>
<div>-eric<br>
<br>
<div>On Wed Dec 18 2013 at 4:49:16 PM, Reed Kotler <<a href="mailto:rkotler@mips.com" target="_blank">rkotler@mips.com</a>> wrote:</div>
<blockquote style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Author: rkotler<br>
Date: Wed Dec 18 18:43:08 2013<br>
New Revision: 197638<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=197638&view=rev" target="_blank">
http://llvm.org/viewvc/llvm-<u></u>project?rev=197638&view=rev</a><br>
Log:<br>
Make cosmetic changes as part of Mips internal post commit review of<br>
patch r196331.<br>
<br>
<br>
Modified:<br>
llvm/trunk/lib/Target/Mips/<u></u>MipsConstantIslandPass.cpp<br>
<br>
Modified: llvm/trunk/lib/Target/Mips/<u></u>MipsConstantIslandPass.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/Mips/MipsConstantIslandPass.cpp?rev=197638&r1=197637&r2=197638&view=diff" target="_blank">
http://llvm.org/viewvc/llvm-<u></u>project/llvm/trunk/lib/Target/<u></u>Mips/MipsConstantIslandPass.<u></u>cpp?rev=197638&r1=197637&r2=<u></u>197638&view=diff</a><br>
==============================<u></u>==============================<u></u>==================<br>
--- llvm/trunk/lib/Target/Mips/<u></u>MipsConstantIslandPass.cpp (original)<br>
+++ llvm/trunk/lib/Target/Mips/<u></u>MipsConstantIslandPass.cpp Wed Dec 18 18:43:08 2013<br>
@@ -1625,7 +1625,7 @@ MipsConstantIslands::<u></u>fixupConditionalBr(<br>
MachineBasicBlock *MBB = MI->getParent();<br>
MachineInstr *BMI = &MBB->back();<br>
bool NeedSplit = (BMI != MI) || !BBHasFallthrough(MBB);<br>
- unsigned OppositeBranchOpcode=TII-><u></u>getOppositeBranchOpc(Opcode);<br>
+ unsigned OppositeBranchOpcode = TII->getOppositeBranchOpc(<u></u>Opcode);<br>
<br>
++NumCBrFixed;<br>
if (BMI != MI) {<br>
@@ -1674,9 +1674,9 @@ MipsConstantIslands::<u></u>fixupConditionalBr(<br>
BuildMI(MBB, DebugLoc(), TII->get(OppositeBranchOpcode)<u></u>)<br>
.addReg(MI->getOperand(0).<u></u>getReg())<br>
.addMBB(NextBB);<br>
- }<br>
- else { BuildMI(MBB, DebugLoc(), TII->get(OppositeBranchOpcode)<u></u>)<br>
- .addMBB(NextBB);<br>
+ } else {<br>
+ BuildMI(MBB, DebugLoc(), TII->get(OppositeBranchOpcode)<u></u>)<br>
+ .addMBB(NextBB);<br>
}<br>
Br.MI = &MBB->back();<br>
BBInfo[MBB->getNumber()].Size += TII->GetInstSizeInBytes(&MBB-><u></u>back());<br>
<br>
<br>
______________________________<u></u>_________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/<u></u>mailman/listinfo/llvm-commits</a><br>
</blockquote>
</div>
</div>
</div></div></div></div></div><div><div style="direction:ltr;font-family:Tahoma;color:#000000;font-size:10pt"><div><div><div style="font-family:Times New Roman;color:#000000;font-size:16px"></div>
<div>
<div></div>
<div></div>
<div>
<div>
<div>
<div></div>
<table cellspacing="1" border="0">
<tbody>
<tr>
<td align="left" width="20%">
<div>English »</div>
</td>
<td align="left" width="20%"><select><option value="af">
Afrikaans</option><option value="sq">Albanian</option><option value="ar">Arabic</option><option value="hy">
Armenian</option><option value="az">Azerbaijani</option><option value="eu">Basque
</option><option value="bn">Bengali</option><option value="be">Belarusian</option><option value="bg">
Bulgarian</option><option value="ca">Catalan</option><option value="zh-CN">Chinese (Simp)
</option><option value="zh-TW">Chinese (Trad)</option><option value="hr">Croatian
</option><option value="cs">Czech</option><option value="da">Danish</option><option value="nl">
Dutch</option><option value="en">English</option><option value="eo">Esperanto</option><option value="et">
Estonian</option><option value="tl">Filipino</option><option value="fi">Finnish</option><option value="fr">
French</option><option value="gl">Galician</option><option value="ka">Georgian</option><option value="de">
German</option><option value="el">Greek</option><option value="gu">Gujarati</option><option value="ht">
Haitian Creole</option><option value="iw">Hebrew</option><option value="hi">Hindi
</option><option value="hu">Hungarian</option><option value="is">Icelandic</option><option value="id">
Indonesian</option><option value="ga">Irish</option><option value="it">Italian</option><option value="ja">
Japanese</option><option value="kn">Kannada</option><option value="ko">Korean</option><option value="lo">
Lao</option><option value="la">Latin</option><option value="lv">Latvian</option><option value="lt">
Lithuanian</option><option value="mk">Macedonian</option><option value="ms">Malay
</option><option value="mt">Maltese</option><option value="no">Norwegian</option><option value="fa">
Persian</option><option value="pl">Polish</option><option value="pt">Portuguese</option><option value="ro">
Romanian</option><option value="ru">Russian</option><option value="sr">Serbian</option><option value="sk">
Slovak</option><option value="sl">Slovenian</option><option selected value="es">
Spanish</option><option value="sw">Swahili</option><option value="sv">Swedish</option><option value="ta">
Tamil</option><option value="te">Telugu</option><option value="th">Thai</option><option value="tr">
Turkish</option><option value="uk">Ukrainian</option><option value="ur">Urdu</option><option value="vi">
Vietnamese</option><option value="cy">Welsh</option><option value="yi">Yiddish</option></select></td>
<td width="13%" align="center"> </td>
<td width="8%" align="center">
<div title="Listen to the translation"></div>
</td>
<td width="8%" align="center">
<div title="Select text"></div>
</td>
<td width="8%" align="center">
<div title="Font size"></div>
</td>
<td width="8%" align="center"><a>
<div title="Translation history"></div>
</a></td>
<td width="5%"></td>
<td width="8%" align="right">
<div title="Pin pup-up bubble"></div>
</td>
</tr>
</tbody>
</table>
</div>
</div>
<div></div>
<div title="Make a small contribution"></div>
<div><a title="Feedback">Feedback</a> : <a title="Translation history">History</a> : <a title="Show options">Options</a></div>
</div>
</div>
</div>
</div>
</div>
</div>
</blockquote>