<div dir="ltr">Thank you! I'll go and dig out some patience somewhere :-) It is just annoying to see a buildbot fail hundreds of times.<div><br></div><div><br></div><div>-- Mikael</div></div><div class="gmail_extra">
<br><br><div class="gmail_quote">2013/12/17 David Blaikie <span dir="ltr"><<a href="mailto:dblaikie@gmail.com" target="_blank">dblaikie@gmail.com</a>></span><br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr"><br><div class="gmail_extra"><br><br><div class="gmail_quote">On Tue, Dec 17, 2013 at 9:21 AM, Mikael Lyngvig <span dir="ltr"><<a href="mailto:mikael@lyngvig.org" target="_blank">mikael@lyngvig.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Please? Is there anybody out there? I've tried to get this 15 character patch commited for for a week now. My builder has now failed some 225 builds because nobody has bothered to commit the patch.</div>
</blockquote><div><br></div><div>Patch review is slow at the best of times - a week is not an extreme amount of time to wait (indeed we usually recommend new contributors ping a patch at about a weekly rate, no higher). Though the buildbot config has even fewer reviewers and Galina is probably the best person to review this as she contributed the original patch - and I can't say for sure why all those flags were used for this setup.<br>
<br>All that being said, I committed something that should suffice in r197519, but I don't know if it'll break other things given the curious set of flags (strict ansi and libc++) that were specified previously.</div>
<div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div>
<br></div><div>Rui has said "LGTM" about it. Chandler has suggested a change to the initial patch which has been implemented in this patch.</div><div><br></div><div>Now I know what I want for Christmas this year! A 15-character patch of Zorg...</div>
<span><font color="#888888">
<div><br></div><div><br></div></font></span><div><span><font color="#888888">-- Mikael</font></span><div><div><br><br><div class="gmail_quote">---------- Forwarded message ----------<br>From: <b class="gmail_sendername">Mikael Lyngvig</b> <span dir="ltr"><<a href="mailto:mikael@lyngvig.org" target="_blank">mikael@lyngvig.org</a>></span><br>
Date: 2013/12/12<br>Subject: [PATCH] Zorg, lld build factory: Remove -stdlib=libc++ as this breaks the GNU build<br>To: LLVM-commits <<a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a>><br>
<br><br>
<div dir="ltr">Anyone? My builder keeps failing until this patch is committed.<div><br></div><div><div>Index: zorg/buildbot/builders/LLDBuilder.py</div><div>===================================================================</div>
<div>--- zorg/buildbot/builders/LLDBuilder.py<span style="white-space:pre-wrap"> </span>(revision 196862)</div><div>+++ zorg/buildbot/builders/LLDBuilder.py<span style="white-space:pre-wrap"> </span>(working copy)</div>
<div>@@ -57,10 +57,11 @@</div><div> haltOnFailure=False,</div><div> description=["create build dir"],</div><div> workdir="."))</div>
<div>+</div><div> cmakeCommand = [</div><div> "cmake",</div><div> "-DCMAKE_BUILD_TYPE=Release",</div><div>- "-DCMAKE_CXX_FLAGS=\"-Wall -Werror -std=c++11 -stdlib=libc++ -U__STRICT_ANSI__\"",</div>
<div>+ "-DCMAKE_CXX_FLAGS=\"-Wall -Werror -std=c++11 -U__STRICT_ANSI__\"",</div><div> "../%s" % llvm_srcdir]</div><div> # Note: ShellCommand does not pass the params with special symbols right.</div>
<div> # The " ".join is a workaround for this bug.</div></div><span><font color="#888888"><div><br></div><div><br></div><div><br></div><div>-- Mikael</div></font></span></div>
</div><br></div></div></div></div>
<br>_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
<br></blockquote></div><br></div></div>
</blockquote></div><br></div>