<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;">LGTM.<div><br></div><div>Thanks,<br><div apple-content-edited="true">
<div style="color: rgb(0, 0, 0); font-family: Helvetica; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">-Quentin</div>
</div>
<br><div style=""><div>On Dec 16, 2013, at 3:22 AM, Stepan Dyatkovskiy <<a href="mailto:stpworld@narod.ru">stpworld@narod.ru</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite">ping<br>Stepan Dyatkovskiy wrote:<br><blockquote type="cite">Hello,<br><br>Please find fix + test-case in attachment.<br><br>Short description of PR18045 issue:<br>For X86 machines with sse < sse4.1 we got failures for some<br>particular load/store vector sequences:<br><br>$ clang-trunk -m32 -O2 test-case.c<br>fatal error: error in backend: Cannot select: 0x4200920: v4i32,ch = load<br>0x41d6ab0, 0x4205850,<br> 0x41dcb10<LD16[getelementptr inbounds ([4 x i32]* @e, i32 0, i32<br>0)](align=4)> [ORD=82]<br> [ID=58]<br> 0x4205850: i32 = X86ISD::Wrapper 0x41d5490 [ORD=26] [ID=43]<br> 0x41d5490: i32 = TargetGlobalAddress<[4 x i32]* @e> 0 [ORD=26] [ID=23]<br> 0x41dcb10: i32 = undef [ID=2]<br><br>The reason is that EltsFromConsecutiveLoads could emit such load<br>instruction both before and after legalize stage. Though this<br>instruction is not legal for machines with SSSE3 and lower.<br><br>The fix: In EltsFromConsecutiveLoads, if we have passed legalize stage,<br>we check whether nodes it emits are legal.<br><br>-Stepan<br></blockquote><br>_______________________________________________<br>llvm-commits mailing list<br><a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits<br></blockquote></div><br></div></body></html>