<div dir="ltr"><br><div class="gmail_extra"><br><br><div class="gmail_quote">On Fri, Dec 6, 2013 at 1:52 PM, Stepan Dyatkovskiy <span dir="ltr"><<a href="mailto:stpworld@narod.ru" target="_blank">stpworld@narod.ru</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Yep. May be we can pick up something shorter then "Node". Don't think # is the best choice, since '#' is used already (in additional info for load/store instructions).<br>
May be we can use N0, N1, N2, ... form.<br>
<br>
<br>
Though my goal was to improve readability (I didn't try make constructions shorter).<br>
IMHO it is difficult to lookup 0x1234545 in heap </blockquote><div><br></div><div>The addresses may be there so that it is easy to look at nodes in the debugger.</div><div><br></div><div>-- Sean Silva</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
of very similar numbers (0x1324545, 0x1243545, ...).<br>
It is more comfortable to see Node1, Node2, Node3, where Node1 could be introduced only before Node2 and Node3.<br>
<br>
Numbers are not Node IDs actually, but serial numbers assigned to each pointers. For first pointer we assign 0, for second 1 and so on.<br>
<br>
Using this approach you can get easy convert dump with pointers into one with Node<Num>-s.<br>
<br>
-Stepan.<br>
<br>
Mikael Lyngvig wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="im">
Perhaps you should consider to use #ID instead of NodeID (#43 instead of<br>
Node43) as it appears that there may be quite a few nodes in each line<br>
and you thereby can save three characters per node. But as you are<br>
already saving a few characters per node, it may be a silly suggestion.<br>
Just my two pennies.<br>
<br>
<br>
-- Mikael<br>
<br>
<br></div>
2013/12/6 Stepan Dyatkovskiy <<a href="mailto:stpworld@narod.ru" target="_blank">stpworld@narod.ru</a> <mailto:<a href="mailto:stpworld@narod.ru" target="_blank">stpworld@narod.ru</a>>><div class="im"><br>
<br>
Hi all!<br>
I propose DAG dump improvement (for -debug output). To be short just<br>
look at example below:<br>
<br>
Now:<br>
0x3adf4e0: v4i32,ch = load 0x3ab64c0, 0x3ab5680, 0x3abaee0<br>
<LD16[bitcast ([4 x i32]* @f to <4 x<br></div>
i32>*)](align=4)(tbaa=<badref><u></u>__)> [ORD=47] [ID=-3]<div class="im"><br>
<br>
After:<br>
Node47: v4i32,ch = load Node7, Node46, Node26<i32 undef><br>
<LD16[bitcast ([4 x i32]* @f to <4 x<br></div>
i32>*)](align=4)(tbaa=<badref><u></u>__)> [ORD=47] [ID=-3]<div class="im"><br>
<br>
Features:<br>
* Possibility to replace 0xCRAZYNUM with something more<br>
readable (Node<Num>).<br>
You can also setup to output both CRAZYNUM and Node<Num>.<br>
* Constants, registers and undef could be inlined. So you don't need<br>
to lookup top part of dump just to realize that 0x3abaee0 is undef.<br>
It could be inlined in hint mode, or substitution mode.<br>
In last case you will get next output:<br>
Node47: v4i32,ch = load Node7, Node46, i32 undef <LD16[bitcast<br></div>
([4 x i32]* @f to <4 x i32>*)](align=4)(tbaa=<badref><u></u>__)> [ORD=47]<div class="im"><br>
[ID=-3]<br>
<br>
Will wait you reviews, remarks and questions.<br>
<br>
-Stepan<br>
<br>
<br>
______________________________<u></u>_________________<br>
llvm-commits mailing list<br></div>
<a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a> <mailto:<a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.<u></u>edu</a>><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/<u></u>mailman/listinfo/llvm-commits</a><br>
<br>
<br>
</blockquote><div class="HOEnZb"><div class="h5">
<br>
______________________________<u></u>_________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/<u></u>mailman/listinfo/llvm-commits</a><br>
</div></div></blockquote></div><br></div></div>