<div dir="ltr"><div class="gmail_default" style="font-family:arial,helvetica,sans-serif;font-size:small">Hi Ana,</div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif;font-size:small"><br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif;font-size:small">
I mean the 3rd argument should be <span style="white-space:pre-wrap;font-family:arial">float64x2_t rather than </span><span style="white-space:pre-wrap;font-family:arial">float64x1_t, because this intrinsic has contains 'laneq' rather than 'lane'.</span></div>
<div class="gmail_default" style="font-family:arial,helvetica,sans-serif;font-size:small"><br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif;font-size:small"><pre style="white-space:pre-wrap;word-wrap:break-word">
float64x1_t vcopy_laneq_f64(float64x1_t a, const int lane1, float64x2_t b, const int lane2)</pre><pre style="white-space:pre-wrap;word-wrap:break-word"><br></pre><pre style="white-space:pre-wrap;word-wrap:break-word">Thanks,</pre>
<pre style="white-space:pre-wrap;word-wrap:break-word">-Jiangning</pre></div></div><div class="gmail_extra"><br><br><div class="gmail_quote">2013/12/3 Ana Pazos <span dir="ltr"><<a href="mailto:apazos@codeaurora.org" target="_blank">apazos@codeaurora.org</a>></span><br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div lang="EN-US" link="blue" vlink="purple"><div><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">Hi Jiangning,<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"><u></u> <u></u></span></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">- The file head should be unchanged – thanks for catching that deleted line.<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">- The test function does not have the lanes as input parameters, but the intrinsic call does, see the constant zero being passed. The intrinisic is correctly defined.<u></u><u></u></span></p>
<p class="MsoNormal" style="margin-left:.5in"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">float64x1_t test_vcopy_laneq_f64(float64x1_t a, float64x1_t c) {<u></u><u></u></span></p>
<div class="im"><p class="MsoNormal" style="margin-left:.5in"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"> return <b>vcopy_laneq_f64(a, 0, c, 0);<u></u><u></u></b></span></p>
<p class="MsoNormal" style="margin-left:.5in"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">}<u></u><u></u></span></p></div><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">- Will add the missing vcopyq_laneq_f64.<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"><u></u> <u></u></span></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">Will make these changes and check them in today.<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"><u></u> <u></u></span></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">Thanks!<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">Ana.<u></u><u></u></span></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"><u></u> <u></u></span></p>
<p class="MsoNormal"><b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">From:</span></b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif""> Jiangning Liu [mailto:<a href="mailto:liujiangning1@gmail.com" target="_blank">liujiangning1@gmail.com</a>] <br>
<b>Sent:</b> Wednesday, November 27, 2013 6:52 PM<br><b>To:</b> Ana Pazos<br><b>Cc:</b> llvm-commits; <a href="mailto:cfe-commits@cs.uiuc.edu" target="_blank">cfe-commits@cs.uiuc.edu</a>; Jiangning Liu<br><b>Subject:</b> Re: [PATCH][AArch64]Implemented vcopy_lane patterns using scalar dup<u></u><u></u></span></p>
<div><div class="h5"><p class="MsoNormal"><u></u> <u></u></p><div><div><div><p class="MsoNormal"><span style="font-family:"Arial","sans-serif"">@@ -1,6 +1,3 @@</span><u></u><u></u></p></div><div><p class="MsoNormal">
<span style="font-family:"Arial","sans-serif"">-//===-- AArch64InstrNEON.td - NEON support for AArch64 -----*- tablegen -*-===//</span><u></u><u></u></p></div><div><p class="MsoNormal"><span style="font-family:"Arial","sans-serif"">-//</span><u></u><u></u></p>
</div><div><p class="MsoNormal"><span style="font-family:"Arial","sans-serif"">-// The LLVM Compiler Infrastructure</span><u></u><u></u></p></div><div><p class="MsoNormal"><span style="font-family:"Arial","sans-serif""> //</span><u></u><u></u></p>
</div><div><p class="MsoNormal"><span style="font-family:"Arial","sans-serif""> // This file is distributed under the University of Illinois Open Source</span><u></u><u></u></p></div><div><p class="MsoNormal">
<span style="font-family:"Arial","sans-serif""> // License. See LICENSE.TXT for details.</span><u></u><u></u></p></div><div><p class="MsoNormal"><span style="font-family:"Arial","sans-serif""><u></u> <u></u></span></p>
</div><div><p class="MsoNormal"><span style="font-family:"Arial","sans-serif"">We should not remove this file head, should we? <u></u><u></u></span></p></div><div><p class="MsoNormal"><span style="font-family:"Arial","sans-serif""><u></u> <u></u></span></p>
</div><div><div><p class="MsoNormal"><span style="font-family:"Arial","sans-serif"">+// CHECK_AARCH64: test_vcopy_laneq_f64</span><u></u><u></u></p></div><div><p class="MsoNormal"><span style="font-family:"Arial","sans-serif"">+float64x1_t test_vcopy_laneq_f64(float64x1_t a, float64x1_t c) {</span><u></u><u></u></p>
</div><div><p class="MsoNormal"><span style="font-family:"Arial","sans-serif"">+ return vcopy_laneq_f64(a, 0, c, 0);</span><u></u><u></u></p></div><div><p class="MsoNormal"><span style="font-family:"Arial","sans-serif"">+// CHECK: fmov {{d[0-9]+}}, {{d[0-9]+}}</span><u></u><u></u></p>
</div><div><p class="MsoNormal"><span style="font-family:"Arial","sans-serif"">+// CHECK-NOT: dup {{d[0-9]+}}, {{v[0-9]+}}.d[0]</span><u></u><u></u></p></div><div><p class="MsoNormal"><span style="font-family:"Arial","sans-serif"">+}</span><u></u><u></u></p>
</div><div><p class="MsoNormal"><span style="font-family:"Arial","sans-serif""><u></u> <u></u></span></p></div></div><div><p class="MsoNormal"><span style="font-family:"Arial","sans-serif"">vcopy_laneq_f64 should have prototype as below.<u></u><u></u></span></p>
</div><div><pre style="word-wrap:break-word;white-space:pre-wrap"><span style>float64x1_t vcopy_laneq_f64(float64x1_t a, const int lane1, float64x2_t b, const int lane2)<u></u><u></u></span></pre><pre style="word-wrap:break-word;white-space:pre-wrap">
<span style><u></u> <u></u></span></pre><pre style="word-wrap:break-word;white-space:pre-wrap"><span style><u></u> <u></u></span></pre><pre style="word-wrap:break-word;white-space:pre-wrap"><span style="font-family:"Arial","sans-serif";color:#222222">And sorry, one more is missing in the list I previously gave you, </span><span style><br>
<br><u></u><u></u></span></pre><pre style="word-wrap:break-word;white-space:pre-wrap"><span style>float64x2_t vcopyq_laneq_f64(float64x2_t a, const int lane1, float64x2_t b, const int lane2)<u></u><u></u></span></pre><pre style="word-wrap:break-word;white-space:pre-wrap">
<span style><u></u> <u></u></span></pre><pre><span style><u></u> <u></u></span></pre><pre style="word-wrap:break-word;white-space:pre-wrap"><span style="font-family:"Arial","sans-serif";color:#222222">All others LGTM!</span><span style><u></u><u></u></span></pre>
<pre style="word-wrap:break-word;white-space:pre-wrap"><span style><u></u> <u></u></span></pre><pre><span style><u></u> <u></u></span></pre><pre style="word-wrap:break-word;white-space:pre-wrap"><span style="font-family:"Arial","sans-serif";color:#222222">Thanks,</span><span style><u></u><u></u></span></pre>
<pre><span style><u></u> <u></u></span></pre><pre style="word-wrap:break-word;white-space:pre-wrap"><span style="font-family:"Arial","sans-serif";color:#222222">-Jiangning</span><span style><u></u><u></u></span></pre>
<pre style="word-wrap:break-word;white-space:pre-wrap"><span style><u></u> <u></u></span></pre><pre><span style><u></u> <u></u></span></pre></div></div></div><div><p class="MsoNormal" style="margin-bottom:12.0pt"><u></u> <u></u></p>
<div><p class="MsoNormal">2013/11/28 Ana Pazos <<a href="mailto:apazos@codeaurora.org" target="_blank">apazos@codeaurora.org</a>><u></u><u></u></p><div><div><p class="MsoNormal">Hi Jiangning and reviewers,<u></u><u></u></p>
<p class="MsoNormal"> <u></u><u></u></p><p class="MsoNormal">Here is the patch with the vcopy_lane* intrinsics that use scalar dup instructions.<u></u><u></u></p><p class="MsoNormal"> <u></u><u></u></p><p class="MsoNormal">
Send me your review/ok sign, and I will commit them.<u></u><u></u></p><p class="MsoNormal"> <u></u><u></u></p><p class="MsoNormal">Thanks,<u></u><u></u></p><p class="MsoNormal">Ana.<u></u><u></u></p></div></div><p class="MsoNormal" style="margin-bottom:12.0pt">
<br>_______________________________________________<br>cfe-commits mailing list<br><a href="mailto:cfe-commits@cs.uiuc.edu" target="_blank">cfe-commits@cs.uiuc.edu</a><br><a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><u></u><u></u></p>
</div><p class="MsoNormal"><br><br clear="all"><u></u><u></u></p><div><p class="MsoNormal"><u></u> <u></u></p></div><p class="MsoNormal">-- <u></u><u></u></p><div><p class="MsoNormal"><span style="font-family:"Courier New"">Thanks,</span><u></u><u></u></p>
<div><p class="MsoNormal"><span style="font-family:"Courier New"">-Jiangning</span><u></u><u></u></p></div></div></div></div></div></div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div dir="ltr">
<font face="courier new, monospace">Thanks,</font><div><font face="courier new, monospace">-Jiangning</font></div></div>
</div>