<div dir="ltr"><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Dec 2, 2013 at 7:41 PM, Sergey Matveev <span dir="ltr"><<a href="mailto:earthdok@google.com" target="_blank">earthdok@google.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: smatveev<br>
Date: Mon Dec  2 09:41:04 2013<br>
New Revision: 196112<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=196112&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=196112&view=rev</a><br>
Log:<br>
[sanitizer] Allow InternalMmapVector construction with zero capacity.<br>
<br>
Modified:<br>
    compiler-rt/trunk/lib/sanitizer_common/sanitizer_common.h<br>
<br>
Modified: compiler-rt/trunk/lib/sanitizer_common/sanitizer_common.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/sanitizer_common/sanitizer_common.h?rev=196112&r1=196111&r2=196112&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/sanitizer_common/sanitizer_common.h?rev=196112&r1=196111&r2=196112&view=diff</a><br>

==============================================================================<br>
--- compiler-rt/trunk/lib/sanitizer_common/sanitizer_common.h (original)<br>
+++ compiler-rt/trunk/lib/sanitizer_common/sanitizer_common.h Mon Dec  2 09:41:04 2013<br>
@@ -320,8 +320,7 @@ template<typename T><br>
 class InternalMmapVector {<br>
  public:<br>
   explicit InternalMmapVector(uptr initial_capacity) {<br>
-    CHECK_GT(initial_capacity, 0);<br>
-    capacity_ = initial_capacity; </blockquote><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
+    capacity_ = Min(initial_capacity, (uptr)1);<br></blockquote><div><br></div><div>Really?</div><div>This code will also crash if you try to mmap 0-sized vector. I've fixed this and added a test in r196263.</div><div>
 </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
     size_ = 0;<br>
     data_ = (T *)MmapOrDie(capacity_ * sizeof(T), "InternalMmapVector");<br>
   }<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div>Alexey Samsonov, MSK</div>
</div></div>