<div dir="ltr"><div><div><div><div><div>Oh, it breaks nothing. <br><br>There was a misinformation email by <span class="GINGER_SOFATWARE_mark" id="31894382-0cbb-4f30-ba1a-4212377d3999">buildbot</span>: <a href="http://lab.llvm.org:8011/builders/lldb-x86_64-darwin12/builds/7174">http://lab.llvm.org:8011/builders/lldb-x86_64-darwin12/builds/7174</a>, which told me that my commit causing a build failure.<br>
</div><br>I thought it was my fault, because there is only me on the blame list. So I reverted it.<br><br>Then, I tried my patch again and couldn't find any build failures. So I recommitted it in r195432 <a href="http://llvm.org/viewvc/llvm-project?view=revision&revision=195432">http://llvm.org/viewvc/llvm-project?view=revision&revision=195432</a>. And I never received any <span class="GINGER_SOFATWARE_mark" id="c6cd30df-bc5d-402d-97be-c9d0800301ae">buildbot</span> failure email.<br>
</div><br></div>It seems that email is incorrect. Now this patch is in <span class="GINGER_SOFATWARE_mark" id="d017b085-2e37-4a88-b305-88818640c5c7">trunk</span>.<br><br></div>Thanks,<br></div>-<span class="" id="e5933786-0bc4-41a7-97c6-8f445deeda89">Hao</span><br>
<div><div><div><div><div><div><div><br></div></div></div></div></div></div></div></div><div class="gmail_extra"><br><br><div class="gmail_quote">2013/11/22 NAKAMURA Takumi <span dir="ltr"><<a href="mailto:geek4civic@gmail.com" target="_blank">geek4civic@gmail.com</a>></span><br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">I don't understand what you broke. Lemme know, please?<br>
<br>
2013/11/22 Hao Liu <<a href="mailto:Hao.Liu@arm.com">Hao.Liu@arm.com</a>>:<br>
<div class="HOEnZb"><div class="h5">> Author: haoliu<br>
> Date: Fri Nov 22 02:34:54 2013<br>
> New Revision: 195423<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=195423&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=195423&view=rev</a><br>
> Log:<br>
> Revert last change by haoliu because of buildbot failure.<br>
><br>
> Modified:<br>
> llvm/trunk/lib/Target/AArch64/AArch64RegisterInfo.td<br>
> llvm/trunk/lib/Target/AArch64/AsmParser/AArch64AsmParser.cpp<br>
> llvm/trunk/lib/Target/AArch64/InstPrinter/AArch64InstPrinter.cpp<br>
> llvm/trunk/lib/Target/AArch64/Utils/AArch64BaseInfo.h<br>
><br>
> Modified: llvm/trunk/lib/Target/AArch64/AArch64RegisterInfo.td<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/AArch64/AArch64RegisterInfo.td?rev=195423&r1=195422&r2=195423&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/AArch64/AArch64RegisterInfo.td?rev=195423&r1=195422&r2=195423&view=diff</a><br>
> ==============================================================================<br>
> --- llvm/trunk/lib/Target/AArch64/AArch64RegisterInfo.td (original)<br>
> +++ llvm/trunk/lib/Target/AArch64/AArch64RegisterInfo.td Fri Nov 22 02:34:54 2013<br>
> @@ -261,12 +261,12 @@ multiclass VectorList_operands<string PR<br>
> let Name = PREFIX # LAYOUT # Count;<br>
> let RenderMethod = "addVectorListOperands";<br>
> let PredicateMethod =<br>
> - "isVectorList<A64Layout::VL_" # LAYOUT # ", " # Count # ">";<br>
> + "isVectorList<A64Layout::_" # LAYOUT # ", " # Count # ">";<br>
> let ParserMethod = "ParseVectorList";<br>
> }<br>
><br>
> def _operand : RegisterOperand<RegList,<br>
> - "printVectorList<A64Layout::VL_" # LAYOUT # ", " # Count # ">"> {<br>
> + "printVectorList<A64Layout::_" # LAYOUT # ", " # Count # ">"> {<br>
> let ParserMatchClass =<br>
> !cast<AsmOperandClass>(PREFIX # LAYOUT # "_asmoperand");<br>
> }<br>
><br>
> Modified: llvm/trunk/lib/Target/AArch64/AsmParser/AArch64AsmParser.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/AArch64/AsmParser/AArch64AsmParser.cpp?rev=195423&r1=195422&r2=195423&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/AArch64/AsmParser/AArch64AsmParser.cpp?rev=195423&r1=195422&r2=195423&view=diff</a><br>
> ==============================================================================<br>
> --- llvm/trunk/lib/Target/AArch64/AsmParser/AArch64AsmParser.cpp (original)<br>
> +++ llvm/trunk/lib/Target/AArch64/AsmParser/AArch64AsmParser.cpp Fri Nov 22 02:34:54 2013<br>
> @@ -2066,7 +2066,7 @@ AArch64AsmParser::OperandMatchResultTy A<br>
><br>
> A64Layout::VectorLayout Layout = A64StringToVectorLayout(LayoutStr);<br>
> if (Count > 1) { // If count > 1, create vector list using super register.<br>
> - bool IsVec64 = (Layout < A64Layout::VL_16B);<br>
> + bool IsVec64 = (Layout < A64Layout::_16B);<br>
> static unsigned SupRegIDs[3][2] = {<br>
> { AArch64::QPairRegClassID, AArch64::DPairRegClassID },<br>
> { AArch64::QTripleRegClassID, AArch64::DTripleRegClassID },<br>
> @@ -2084,10 +2084,10 @@ AArch64AsmParser::OperandMatchResultTy A<br>
> if (Parser.getTok().is(AsmToken::LBrac)) {<br>
> uint32_t NumLanes = 0;<br>
> switch(Layout) {<br>
> - case A64Layout::VL_B : NumLanes = 16; break;<br>
> - case A64Layout::VL_H : NumLanes = 8; break;<br>
> - case A64Layout::VL_S : NumLanes = 4; break;<br>
> - case A64Layout::VL_D : NumLanes = 2; break;<br>
> + case A64Layout::_B : NumLanes = 16; break;<br>
> + case A64Layout::_H : NumLanes = 8; break;<br>
> + case A64Layout::_S : NumLanes = 4; break;<br>
> + case A64Layout::_D : NumLanes = 2; break;<br>
> default:<br>
> SMLoc Loc = getLexer().getLoc();<br>
> Error(Loc, "expected comma before next operand");<br>
><br>
> Modified: llvm/trunk/lib/Target/AArch64/InstPrinter/AArch64InstPrinter.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/AArch64/InstPrinter/AArch64InstPrinter.cpp?rev=195423&r1=195422&r2=195423&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/AArch64/InstPrinter/AArch64InstPrinter.cpp?rev=195423&r1=195422&r2=195423&view=diff</a><br>
> ==============================================================================<br>
> --- llvm/trunk/lib/Target/AArch64/InstPrinter/AArch64InstPrinter.cpp (original)<br>
> +++ llvm/trunk/lib/Target/AArch64/InstPrinter/AArch64InstPrinter.cpp Fri Nov 22 02:34:54 2013<br>
> @@ -521,7 +521,7 @@ void AArch64InstPrinter::printVectorList<br>
> std::string LayoutStr = A64VectorLayoutToString(Layout);<br>
> O << "{";<br>
> if (Count > 1) { // Print sub registers separately<br>
> - bool IsVec64 = (Layout < A64Layout::VL_16B);<br>
> + bool IsVec64 = (Layout < A64Layout::_16B);<br>
> unsigned SubRegIdx = IsVec64 ? AArch64::dsub_0 : AArch64::qsub_0;<br>
> for (unsigned I = 0; I < Count; I++) {<br>
> std::string Name = getRegisterName(MRI.getSubReg(Reg, SubRegIdx++));<br>
><br>
> Modified: llvm/trunk/lib/Target/AArch64/Utils/AArch64BaseInfo.h<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/AArch64/Utils/AArch64BaseInfo.h?rev=195423&r1=195422&r2=195423&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/AArch64/Utils/AArch64BaseInfo.h?rev=195423&r1=195422&r2=195423&view=diff</a><br>
> ==============================================================================<br>
> --- llvm/trunk/lib/Target/AArch64/Utils/AArch64BaseInfo.h (original)<br>
> +++ llvm/trunk/lib/Target/AArch64/Utils/AArch64BaseInfo.h Fri Nov 22 02:34:54 2013<br>
> @@ -309,40 +309,40 @@ namespace A64SE {<br>
> namespace A64Layout {<br>
> enum VectorLayout {<br>
> Invalid = -1,<br>
> - VL_8B,<br>
> - VL_4H,<br>
> - VL_2S,<br>
> - VL_1D,<br>
> + _8B,<br>
> + _4H,<br>
> + _2S,<br>
> + _1D,<br>
><br>
> - VL_16B,<br>
> - VL_8H,<br>
> - VL_4S,<br>
> - VL_2D,<br>
> + _16B,<br>
> + _8H,<br>
> + _4S,<br>
> + _2D,<br>
><br>
> // Bare layout for the 128-bit vector<br>
> // (only show ".b", ".h", ".s", ".d" without vector number)<br>
> - VL_B,<br>
> - VL_H,<br>
> - VL_S,<br>
> - VL_D<br>
> + _B,<br>
> + _H,<br>
> + _S,<br>
> + _D<br>
> };<br>
> }<br>
><br>
> inline static const char *<br>
> A64VectorLayoutToString(A64Layout::VectorLayout Layout) {<br>
> switch (Layout) {<br>
> - case A64Layout::VL_8B: return ".8b";<br>
> - case A64Layout::VL_4H: return ".4h";<br>
> - case A64Layout::VL_2S: return ".2s";<br>
> - case A64Layout::VL_1D: return ".1d";<br>
> - case A64Layout::VL_16B: return ".16b";<br>
> - case A64Layout::VL_8H: return ".8h";<br>
> - case A64Layout::VL_4S: return ".4s";<br>
> - case A64Layout::VL_2D: return ".2d";<br>
> - case A64Layout::VL_B: return ".b";<br>
> - case A64Layout::VL_H: return ".h";<br>
> - case A64Layout::VL_S: return ".s";<br>
> - case A64Layout::VL_D: return ".d";<br>
> + case A64Layout::_8B: return ".8b";<br>
> + case A64Layout::_4H: return ".4h";<br>
> + case A64Layout::_2S: return ".2s";<br>
> + case A64Layout::_1D: return ".1d";<br>
> + case A64Layout::_16B: return ".16b";<br>
> + case A64Layout::_8H: return ".8h";<br>
> + case A64Layout::_4S: return ".4s";<br>
> + case A64Layout::_2D: return ".2d";<br>
> + case A64Layout::_B: return ".b";<br>
> + case A64Layout::_H: return ".h";<br>
> + case A64Layout::_S: return ".s";<br>
> + case A64Layout::_D: return ".d";<br>
> default: llvm_unreachable("Unknown Vector Layout");<br>
> }<br>
> }<br>
> @@ -350,18 +350,18 @@ A64VectorLayoutToString(A64Layout::Vecto<br>
> inline static A64Layout::VectorLayout<br>
> A64StringToVectorLayout(StringRef LayoutStr) {<br>
> return StringSwitch<A64Layout::VectorLayout>(LayoutStr)<br>
> - .Case(".8b", A64Layout::VL_8B)<br>
> - .Case(".4h", A64Layout::VL_4H)<br>
> - .Case(".2s", A64Layout::VL_2S)<br>
> - .Case(".1d", A64Layout::VL_1D)<br>
> - .Case(".16b", A64Layout::VL_16B)<br>
> - .Case(".8h", A64Layout::VL_8H)<br>
> - .Case(".4s", A64Layout::VL_4S)<br>
> - .Case(".2d", A64Layout::VL_2D)<br>
> - .Case(".b", A64Layout::VL_B)<br>
> - .Case(".h", A64Layout::VL_H)<br>
> - .Case(".s", A64Layout::VL_S)<br>
> - .Case(".d", A64Layout::VL_D)<br>
> + .Case(".8b", A64Layout::_8B)<br>
> + .Case(".4h", A64Layout::_4H)<br>
> + .Case(".2s", A64Layout::_2S)<br>
> + .Case(".1d", A64Layout::_1D)<br>
> + .Case(".16b", A64Layout::_16B)<br>
> + .Case(".8h", A64Layout::_8H)<br>
> + .Case(".4s", A64Layout::_4S)<br>
> + .Case(".2d", A64Layout::_2D)<br>
> + .Case(".b", A64Layout::_B)<br>
> + .Case(".h", A64Layout::_H)<br>
> + .Case(".s", A64Layout::_S)<br>
> + .Case(".d", A64Layout::_D)<br>
> .Default(A64Layout::Invalid);<br>
> }<br>
><br>
><br>
><br>
> _______________________________________________<br>
> llvm-commits mailing list<br>
> <a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</div></div></blockquote></div><br></div>