<div dir="ltr"><div><div><div>Hi,<br><br>Eric found a build failure on Cygwin caused by enum value names started with a '_'.<br><br></div>This simple patch renams such values and will solve the problem. As this patch only renames the values in enum, we don't need any additional test cases. As this is only a very simple patch, I don't know whether it needs code review.<br>
<br></div><div>If it is OK, I'll commit it to the trunk.<br></div><div><br></div>Thanks,<br></div>-Hao<br><div><div><div><div><div><br>---------- Forwarded message ----------<br>From: <b class="gmail_sendername">Eric Niebler</b> <span dir="ltr"><<a href="mailto:eniebler@boost.org">eniebler@boost.org</a>></span><br>
Date: 2013/11/20<br>Subject: [<span class="" id="72b5c788-70e2-4304-9b7d-fb98246de161">cfe</span>-dev] build failure: AArch64BaseInfo<span class="" id="7de57613-2c37-4a7c-995c-6ec085ebfcc1">.</span><span class="" id="674bec32-8b41-4585-8d6a-490573770e81">h</span> has questionable <span class="" id="ca7fc10a-9f7b-4346-b9aa-a183f60e4b37">enum</span> values<br>
To: <a href="mailto:cfe-dev@cs.uiuc.edu">cfe-dev@cs.uiuc.edu</a><br><br><br><span class="" id="4694112e-6cdb-4e68-a3dd-c0bb59f5e852">lib</span>/Target/AArch64/Utils/<div class="gmail_quote">AArch64BaseInfo<span class="" id="5161c63f-562c-4051-8ca2-e95f04f79aea">.</span><span class="" id="e2a1083e-2d44-4058-951e-273884aabb3c">h</span> has the following <span class="" id="9ec8cd55-05ad-4a07-8c6b-7c6159cc0df6">enum</span>:<br>

<br>
<span class="" id="d46df9a2-d815-4be6-859b-5439779d7805">namespace</span> A64Layout {<br>
    <span class="" id="d012046c-6dc9-4b67-9ecb-ac96d66a91ed">enum</span> <span class="" id="32bdca03-b369-47ca-bbeb-22afa6c160da">VectorLayout</span> {<br>
        Invalid = -1,<br>
/*...*<br>
        // Bare layout for the 128-bit vector<br>
        // (<span class="" id="f6bd5d9d-1020-406e-bb51-15ed6b154d96">only</span> show "<span class="" id="5fb63403-ff0f-4858-9a0b-68fd7e2098c4">.</span>b", "<span class="" id="1c52d4cd-12a3-43aa-b247-ee79033a0941">.</span>h", "<span class="" id="d32c6a39-c901-4856-ab12-5c55e09402b4">.</span>s", "<span class="" id="cec3e9b1-5748-42a9-9955-9716bf81e093">.</span>d" without vector number)<br>

        _B,<br>
        _H,<br>
        _S,<br>
        _D<br>
    };<br>
}<br>
<br>
My build on <span class="" id="1f7afddd-cbb1-44d4-8625-4379efb646b2">cygwin</span> fails because _B and _S are platform macros. Besides,<br>
<span class="" id="dae5b789-0856-4186-9e34-2f869fbbc370">in</span> C++ identifiers with a leading underscore-capital <span class="" id="1f154a39-2346-4c48-9db0-d1bb242ff410">are reserved</span>. I<br>
<span class="" id="808898b3-1eb6-48e5-9142-03f77f9ebedb">suggest</span> changing these four.</div></div></div></div></div></div></div>