<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<div class="moz-cite-prefix">Really strange, Your patch LGTM.<br>
<br>
PS: looks like all the comments thats replied to reviews, doesnot
go in the phabricator page. I think we should just use the review
page to reply, so that we have it in the page.<br>
<br>
Thanks<br>
<br>
Shankar Easwaran<br>
<br>
On 11/20/2013 11:36 AM, Rui Ueyama wrote:<br>
</div>
<blockquote
cite="mid:CAJENXgtUUVYsCWv-A0sVzagZ331SQtiE+6P5fBgs3QxbbO7iPA@mail.gmail.com"
type="cite">
<pre wrap="">On Wed, Nov 20, 2013 at 9:02 AM, Shankar Kalpathi Easwaran <
<a class="moz-txt-link-abbreviated" href="mailto:shankarke@gmail.com">shankarke@gmail.com</a>> wrote:
</pre>
<blockquote type="cite">
<pre wrap="">
The main problem I have here understanding is
handleFile is called when looking at kindObject files. If I have an
undefined symbol in the object file with a fallback atom, i think its too
early to use the fallback atom instead of the undefined atom, when looking
at that single object file.
For example :
Say you have
lld -flavor link hello.o libc.a (the link line may not look like this,
but only taking this as an example).
Currently when the resolver reads in hello.o and say printf has a
fallback to puts, its too early to replace undefined atom printf with puts,
when you have just read hello.o.
Does link.exe have this same behavior ?
</pre>
</blockquote>
<pre wrap="">
Yes. If hello.o contains symbol "printf" with fallback symbol "puts",
"puts" will be searched in libc.a. "printf" won't be searched. If libc.a
has only "printf" and does not have "puts", it will fail to link.
</pre>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
llvm-commits mailing list
<a class="moz-txt-link-abbreviated" href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a>
<a class="moz-txt-link-freetext" href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a>
</pre>
</blockquote>
<br>
<br>
<pre class="moz-signature" cols="72">--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by the Linux Foundation</pre>
</body>
</html>