<div dir="ltr"><br><div class="gmail_extra"><br><br><div class="gmail_quote">On Wed, Nov 20, 2013 at 1:34 PM, Chris Lattner <span dir="ltr"><<a href="mailto:clattner@apple.com" target="_blank">clattner@apple.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div style="word-wrap:break-word"><br><div><div class="im">
<div>On Nov 19, 2013, at 12:28 PM, Benjamin Kramer <<a href="mailto:benny.kra@googlemail.com" target="_blank">benny.kra@googlemail.com</a>> wrote:</div><br><blockquote type="cite"><div style="font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px">
Author: d0k<br>Date: Tue Nov 19 14:28:04 2013<br>New Revision: 195150<br><br>URL:<span> </span><a href="http://llvm.org/viewvc/llvm-project?rev=195150&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=195150&view=rev</a><br>
Log:<br>DataLayout: value initialize globals to avoid static construction.<br></div></blockquote><div dir="auto"><br></div></div><div dir="auto">Nice!  Random thought: how difficult would it be to get globalopt to "constant fold" these initializers?  </div>
</div></div></blockquote><div><br></div><div>It might also be an unlucky product of the current pass ordering. For example, the globalopt failure in <<a href="http://llvm.org/bugs/show_bug.cgi?id=16710">http://llvm.org/bugs/show_bug.cgi?id=16710</a>> can be ameliorated by running an extra `-globalopt -constprop` after the usual -O3 passes have been run.</div>
<div><br></div><div>-- Sean Silva</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div style="word-wrap:break-word">
<div><span class=""><font color="#888888"><div dir="auto"><br></div><div dir="auto">-Chris</div></font></span><div class="im"><div dir="auto"><br></div><br><blockquote type="cite"><div style="font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px">
<br>Modified:<br>   llvm/trunk/lib/IR/DataLayout.cpp<br><br>Modified: llvm/trunk/lib/IR/DataLayout.cpp<br>URL:<span> </span><a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/IR/DataLayout.cpp?rev=195150&r1=195149&r2=195150&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/IR/DataLayout.cpp?rev=195150&r1=195149&r2=195150&view=diff</a><br>
==============================================================================<br>--- llvm/trunk/lib/IR/DataLayout.cpp (original)<br>+++ llvm/trunk/lib/IR/DataLayout.cpp Tue Nov 19 14:28:04 2013<br>@@ -118,7 +118,7 @@ LayoutAlignElem::operator==(const Layout<br>
}<br><br>const LayoutAlignElem<br>-DataLayout::InvalidAlignmentElem = LayoutAlignElem::get(INVALID_ALIGN, 0, 0, 0);<br>+DataLayout::InvalidAlignmentElem = { INVALID_ALIGN, 0, 0, 0 };<br><br>//===----------------------------------------------------------------------===//<br>
// PointerAlignElem, PointerAlign support<br>@@ -145,7 +145,7 @@ PointerAlignElem::operator==(const Point<br>}<br><br>const PointerAlignElem<br>-DataLayout::InvalidPointerElem = PointerAlignElem::get(~0U, 0U, 0U, 0U);<br>
+DataLayout::InvalidPointerElem = { 0U, 0U, 0U, ~0U };<br><br>//===----------------------------------------------------------------------===//<br>//                       DataLayout Class Implementation<br><br><br>_______________________________________________<br>
llvm-commits mailing list<br><a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br><a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a></div>
</blockquote></div></div><br></div><br>_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
<br></blockquote></div><br></div></div>