<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><br><div><div>On Nov 19, 2013, at 4:08 PM, Andrew Trick <<a href="mailto:atrick@apple.com">atrick@apple.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div style="font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><br>On Nov 19, 2013, at 11:50 AM, Filip Pizlo <<a href="mailto:fpizlo@apple.com">fpizlo@apple.com</a>> wrote:<br><br><blockquote type="cite">New patch!<br><br><build-fence.patch><br><br><br>On Nov 19, 2013, at 11:30 AM, Peter Zotov <<a href="mailto:whitequark@whitequark.org">whitequark@whitequark.org</a>> wrote:<br><br><blockquote type="cite">Filip Pizlo писал 19.11.2013 23:22:<br><blockquote type="cite">Hi all!<br>This is a fairly trivial patch to expose the fence instruction to the C API.<br></blockquote><br>1) You forgot to call map_from_llvmordering from LLVMBuildAtomicRMW.<br></blockquote><br>Ooops! Fixed.<br><br><blockquote type="cite">2) I would accept a Name parameter in the LLVMBuildFence function, as all other<br>LLVMBuild* functions have it.<br></blockquote><br>Fixed.<br><br><blockquote type="cite">3) I've done some similar work in <a href="http://llvm-reviews.chandlerc.com/D2176">http://llvm-reviews.chandlerc.com/D2176</a>,<br>you may want to take a look.<br><br>--<span class="Apple-converted-space"> </span><br>WBR, Peter Zotov.<br></blockquote><br></blockquote><br>+static AtomicOrdering map_from_llvmordering(LLVMAtomicOrdering Ordering) {<br><br>Might as well use LLVM’s current naming conventions for a static function:<br><br>mapFromLLVMOrdering(…)<br></div></blockquote><div><br></div><div>Yup, fixed.</div><br><blockquote type="cite"><div style="font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><br>Otherwise LGTM.<br></div></blockquote><div><br></div><div>Thanks!</div><br><blockquote type="cite"><div style="font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><br>-Andy</div></blockquote></div><br></body></html>