<html><head><meta http-equiv="Content-Type" content="text/html charset=windows-1252"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;">r<span style="font-family: Menlo; font-size: 11px;">194899</span><div><font face="Menlo"><span style="font-size: 11px;"><br></span></font></div><div><font face="Menlo"><span style="font-size: 11px;">—Owen</span></font></div><div><font face="Menlo"><span style="font-size: 11px;"><br></span></font><div style=""><div>On Nov 15, 2013, at 11:29 AM, Owen Anderson <<a href="mailto:resistor@mac.com">resistor@mac.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite">LGTM.<br><br>—Owen<br><br>On Nov 8, 2013, at 3:52 PM, Aditya Nandakumar <<a href="mailto:aditya_nandakumar@apple.com">aditya_nandakumar@apple.com</a>> wrote:<br><br><blockquote type="cite">This change removes the “pushing” and “clearing” of the SmallVector and instead uses const arrays to pass the attributeKinds to AttributeSet::get . There should be a marginal improvement with this.<br><br>Please review<br><br>Thanks<br>Aditya<br><br><IntrinsicEmitter.diff>_______________________________________________<br>llvm-commits mailing list<br><a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits<br></blockquote><br><br>_______________________________________________<br>llvm-commits mailing list<br><a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits<br></blockquote></div><br></div></body></html>