<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"><head><META HTTP-EQUIV="Content-Type" CONTENT="text/html; charset=us-ascii"><meta name=Generator content="Microsoft Word 12 (filtered medium)"><style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Tahoma;
panose-1:2 11 6 4 3 5 4 4 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman","serif";}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
p
{mso-style-priority:99;
mso-margin-top-alt:auto;
margin-right:0cm;
mso-margin-bottom-alt:auto;
margin-left:0cm;
font-size:12.0pt;
font-family:"Times New Roman","serif";}
span.EmailStyle18
{mso-style-type:personal-reply;
font-family:"Calibri","sans-serif";
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:72.0pt 72.0pt 72.0pt 72.0pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]--></head><body lang=EN-GB link=blue vlink=purple><div class=WordSection1><p class=MsoNormal style='margin-bottom:12.0pt'><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D'>In relation to this patch which is making the forms DW_FORM_sec_offset/DW_FORM_data4 be consistent with the Dwarf version, is the best thing at this stage to just not do the DWARF3 checks in the fission related tests?<o:p></o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D'>I think that checking whether fission is requested for Dwarf 3 and deciding on what action to then take to do is something for a future patch.<o:p></o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D'><br>Keith <o:p></o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D'><o:p> </o:p></span></p><div style='border:none;border-left:solid blue 1.5pt;padding:0cm 0cm 0cm 4.0pt'><div><div style='border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0cm 0cm 0cm'><p class=MsoNormal><b><span lang=EN-US style='font-size:10.0pt;font-family:"Tahoma","sans-serif"'>From:</span></b><span lang=EN-US style='font-size:10.0pt;font-family:"Tahoma","sans-serif"'> llvm-commits-bounces@cs.uiuc.edu [mailto:llvm-commits-bounces@cs.uiuc.edu] <b>On Behalf Of </b>Eric Christopher<br><b>Sent:</b> 14 November 2013 22:32<br><b>To:</b> Paul Robinson<br><b>Cc:</b> reviews+D2180+public+84546655657775ea@llvm-reviews.chandlerc.com; llvm-commits@cs.uiuc.edu<br><b>Subject:</b> RE: [PATCH] Use the DWARF form DW_FORM_sec_offset or DW_FORM_data4 depending on the Dwarf version being generated<o:p></o:p></span></p></div></div><p class=MsoNormal><o:p> </o:p></p><p>Good catch. I'd looked for this case but apparently missed it in the diff. Fission is a dwarf5 feature and so this probably shouldn't work since it relies on forms that are only in dwarf5.<o:p></o:p></p><p>-eric<o:p></o:p></p><div><p class=MsoNormal>On Nov 14, 2013 2:18 PM, "Robinson, Paul" <<a href="mailto:Paul_Robinson@playstation.sony.com">Paul_Robinson@playstation.sony.com</a>> wrote:<o:p></o:p></p><p class=MsoNormal>+; RUN: llc -split-dwarf=Enable -O0 %s -mtriple=x86_64-unknown-linux-gnu -filetype=obj -o %t -dwarf-version=3<br><br>This seems weird, fission with DWARF 3... but of course 4 doesn't<br>have it either, so it's no less weird than what we have today.<br><br>It's good to have the forms more consistent with the target version<br>but eventually we might want to be more picky about mix-n-match.<br>--paulr<br><br>> -----Original Message-----<br>> From: <a href="mailto:llvm-commits-bounces@cs.uiuc.edu">llvm-commits-bounces@cs.uiuc.edu</a> [mailto:<a href="mailto:llvm-commits-">llvm-commits-</a><br>> <a href="mailto:bounces@cs.uiuc.edu">bounces@cs.uiuc.edu</a>] On Behalf Of Keith Walker<br>> Sent: Thursday, November 14, 2013 8:29 AM<br>> To: <a href="mailto:echristo@gmail.com">echristo@gmail.com</a>; <a href="mailto:kwalker@arm.com">kwalker@arm.com</a><br>> Cc: <a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>> Subject: [PATCH] Use the DWARF form DW_FORM_sec_offset or DW_FORM_data4<br>> depending on the Dwarf version being generated<br>><br>> Hi echristo,<br>><br>> In Dwarf 3 (and Dwarf 2) attributes whose value are offsets into a<br>> section use the form DW_FORM_data4 whilst in Dwarf 4 and later they use<br>> the form DW_FORM_sec_offset.<br>><br>> This patch updates the places where such attributes are generated to use<br>> the appropriate form depending on the Dwarf version. The DIE entries<br>> affected have the following tags:<br>> DW_AT_stmt_list, DW_AT_ranges, DW_AT_location, DW_AT_GNU_pubnames,<br>> DW_AT_GNU_pubtypes, DW_AT_GNU_addr_base, DW_AT_GNU_ranges_base<br>><br>> It also adds a hidden command line option "--dwarf-version=<uint>" to<br>> llc which allows the version of Dwarf to be generated to override what<br>> is specified in the metadata; this makes it possible to update existing<br>> tests to check the debugging information generated for both Dwarf 4 (the<br>> default) and Dwarf 3 using the same metadata.<br>><br>> <a href="http://llvm-reviews.chandlerc.com/D2180" target="_blank">http://llvm-reviews.chandlerc.com/D2180</a><br>><br>> Files:<br>> lib/CodeGen/AsmPrinter/DwarfCompileUnit.cpp<br>> lib/CodeGen/AsmPrinter/DwarfCompileUnit.h<br>> lib/CodeGen/AsmPrinter/DIE.cpp<br>> lib/CodeGen/AsmPrinter/DwarfDebug.cpp<br>> test/DebugInfo/X86/op_deref.ll<br>> test/DebugInfo/X86/block-capture.ll<br>> test/DebugInfo/X86/DW_AT_stmt_list_sec_offset.ll<br>> test/DebugInfo/X86/gnu-public-names.ll<br>> test/DebugInfo/X86/fission-cu.ll<br>> test/DebugInfo/X86/stmt-list-multiple-compile-units.ll<o:p></o:p></p></div></div></div></body></html>