<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"><head><meta http-equiv=Content-Type content="text/html; charset=us-ascii"><meta name=Generator content="Microsoft Word 14 (filtered medium)"><style><!--
/* Font Definitions */
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Tahoma;
panose-1:2 11 6 4 3 5 4 4 2 4;}
@font-face
{font-family:Consolas;
panose-1:2 11 6 9 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman","serif";
color:black;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
pre
{mso-style-priority:99;
mso-style-link:"HTML Preformatted Char";
margin:0in;
margin-bottom:.0001pt;
font-size:10.0pt;
font-family:"Courier New";
color:black;}
span.hoenzb
{mso-style-name:hoenzb;}
span.HTMLPreformattedChar
{mso-style-name:"HTML Preformatted Char";
mso-style-priority:99;
mso-style-link:"HTML Preformatted";
font-family:"Consolas","serif";
color:black;}
span.EmailStyle20
{mso-style-type:personal-reply;
font-family:"Calibri","sans-serif";
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]--></head><body bgcolor=white lang=EN-US link=blue vlink=purple><div class=WordSection1><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D'>Status: System in swap overnight. Stopped both buildmaster and slave. 187 llvm-symbolizer tasks were still running. Tasks did not stop after<o:p></o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D'><o:p> </o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D'>Retried this morning, no other workload, 8 llvm-symbolizer tasks consuming 100% on each cpu. 7 zombie tasks.<o:p></o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D'><o:p> </o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D'>So not quite ready this morning. If anyone knows of an llvm-sanitizer issue like this it would help.<o:p></o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D'><o:p> </o:p></span></p><div><div style='border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0in 0in 0in'><p class=MsoNormal><b><span style='font-size:10.0pt;font-family:"Tahoma","sans-serif";color:windowtext'>From:</span></b><span style='font-size:10.0pt;font-family:"Tahoma","sans-serif";color:windowtext'> llvm-commits-bounces@cs.uiuc.edu [mailto:llvm-commits-bounces@cs.uiuc.edu] <b>On Behalf Of </b>Rick Foos<br><b>Sent:</b> Wednesday, November 13, 2013 1:42 PM<br><b>To:</b> Sergey Matveev; Shankar Easwaran<br><b>Cc:</b> llvm-commits@cs.uiuc.edu; Galina Kistanova<br><b>Subject:</b> Re: [lld] r194545 - [PECOFF] Fix use-after-return.<o:p></o:p></span></p></div></div><p class=MsoNormal><o:p> </o:p></p><div><p class=MsoNormal>Sorry for the delay, <br><br>Our problem with running the sanitizers is that the load average running under Ninja reached 146 and a short time after a system crash requiring calling someone to power cycle the box...<br><br>The address sanitizer by itself leaves a load average 40. This means the OS over 100% utilization, and is thrashing a bit. Load Average doesn't say what exactly is thrashing.<br><br>Ninja supports make's -j, and -l options. The -l maximum load average, is the key. <br><br>The load average should be less than the total number of cores (hyperthreads too) before Ninja launches another task. <br><br>A Load Average at or lower than 100% technically should benefit performance, and maximize throughput. However, I will be happy if I don't have to call someone to power cycle the server :)<br><br>So the maximum load average of a 16 core machine with hyperthreads is 32 (keeping it simple). This needs to be passed to all make's and Ninja build steps on that slave to maximize throughput.<br><br>For now, I'm looking at a minimal patch to include jobs and a new loadaverage variable for the sanitizers. <br><br>Longer term, all buildslaves should define maximum loadaverage, and all make/ninja steps should pass -j, and -l options.<br><br>Best Regards,<br>Rick<br><br>On 11/13/2013 11:21 AM, Sergey Matveev wrote:<o:p></o:p></p></div><blockquote style='margin-top:5.0pt;margin-bottom:5.0pt'><div><p class=MsoNormal>+kcc<o:p></o:p></p></div><div><p class=MsoNormal style='margin-bottom:12.0pt'><o:p> </o:p></p><div><p class=MsoNormal>On Wed, Nov 13, 2013 at 6:41 AM, Shankar Easwaran <<a href="mailto:shankare@codeaurora.org" target="_blank">shankare@codeaurora.org</a>> wrote:<o:p></o:p></p><p class=MsoNormal>Sorry for another indirection. Rick foos is working on it. I think there is some good news here :)<br><br>Cced Rick + adding Galina,Dmitri.<br><br>Thanks<br><br>Shankar Easwaran <o:p></o:p></p><div><div><p class=MsoNormal><br><br>On 11/12/2013 8:37 PM, Rui Ueyama wrote:<o:p></o:p></p><p class=MsoNormal style='margin-bottom:12.0pt'>Shankar tried to set it up recently.<br><br><br>On Tue, Nov 12, 2013 at 6:31 PM, Sean Silva <<a href="mailto:silvas@purdue.edu" target="_blank">silvas@purdue.edu</a>> wrote:<o:p></o:p></p><p class=MsoNormal style='margin-bottom:12.0pt'>Sanitizers?<br><br>There have been a couple of these sorts of bugs recently... we really<br>ought to have some sanitizer bots...<br><br>-- Sean Silva<br><br><br>On Tue, Nov 12, 2013 at 9:21 PM, Rui Ueyama <<a href="mailto:ruiu@google.com" target="_blank">ruiu@google.com</a>> wrote:<o:p></o:p></p><p class=MsoNormal style='margin-bottom:12.0pt'>Author: ruiu<br>Date: Tue Nov 12 20:21:51 2013<br>New Revision: 194545<br><br>URL: <a href="http://llvm.org/viewvc/llvm-project?rev=194545&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=194545&view=rev</a><br>Log:<br>[PECOFF] Fix use-after-return.<br><br>Modified:<br> lld/trunk/lib/Driver/WinLinkDriver.cpp<br><br>Modified: lld/trunk/lib/Driver/WinLinkDriver.cpp<br>URL:<br><a href="http://llvm.org/viewvc/llvm-project/lld/trunk/lib/Driver/WinLinkDriver.cpp?rev=194545&r1=194544&r2=194545&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/lld/trunk/lib/Driver/WinLinkDriver.cpp?rev=194545&r1=194544&r2=194545&view=diff</a><br><br>==============================================================================<br>--- lld/trunk/lib/Driver/WinLinkDriver.cpp (original)<br>+++ lld/trunk/lib/Driver/WinLinkDriver.cpp Tue Nov 12 20:21:51 2013<br>@@ -842,7 +842,7 @@ WinLinkDriver::parse(int argc, const cha<br><br> case OPT_INPUT:<br> inputElements.push_back(std::unique_ptr<InputElement>(<br>- new PECOFFFileNode(ctx, inputArg->getValue())));<br>+ new PECOFFFileNode(ctx,<br>ctx.allocateString(inputArg->getValue()))));<br> break;<br><br> #define DEFINE_BOOLEAN_FLAG(name, setter) \<br>@@ -892,9 +892,11 @@ WinLinkDriver::parse(int argc, const cha<br> // start with a hypen or a slash. This is not compatible with link.exe<br> // but useful for us to test lld on Unix.<br> if (llvm::opt::Arg *dashdash = parsedArgs->getLastArg(OPT_DASH_DASH)) {<br>- for (const StringRef value : dashdash->getValues())<br>- inputElements.push_back(<br>- std::unique_ptr<InputElement>(new PECOFFFileNode(ctx, value)));<br>+ for (const StringRef value : dashdash->getValues()) {<br>+ std::unique_ptr<InputElement> elem(<br>+ new PECOFFFileNode(ctx, ctx.allocateString(value)));<br>+ inputElements.push_back(std::move(elem));<br>+ }<br> }<br><br> // Add the libraries specified by /defaultlib unless they are already<br>added<br><br><br>_______________________________________________<br>llvm-commits mailing list<br><a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br><a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><o:p></o:p></p><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal style='margin-bottom:12.0pt'><o:p> </o:p></p></div></div><p class=MsoNormal><span class=hoenzb><span style='color:#888888'>-- </span></span><span style='color:#888888'><br><span class=hoenzb>Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by the Linux Foundation</span></span> <o:p></o:p></p><div><div><p class=MsoNormal><br><br>_______________________________________________<br>llvm-commits mailing list<br><a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br><a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><o:p></o:p></p></div></div></div><p class=MsoNormal><o:p> </o:p></p></div><p class=MsoNormal><br><br><br><o:p></o:p></p><pre>_______________________________________________<o:p></o:p></pre><pre>llvm-commits mailing list<o:p></o:p></pre><pre><a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><o:p></o:p></pre><pre><a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><o:p></o:p></pre></blockquote><p class=MsoNormal><br><br><br><o:p></o:p></p><pre>-- <o:p></o:p></pre><pre>Rick Foos<o:p></o:p></pre><pre>Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation<o:p></o:p></pre></div></body></html>