<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Thu, Nov 14, 2013 at 3:24 PM, Hans Wennborg <span dir="ltr"><<a href="mailto:hans@hanshq.net" target="_blank">hans@hanshq.net</a>></span> wrote:<br>

<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">Author: hans<br>
Date: Thu Nov 14 17:24:09 2013<br>
New Revision: 194747<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=194747&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=194747&view=rev</a><br>
Log:<br>
Add #include raw_ostream.h in lib/Target/R600/SIFixSGPRCopies.cpp<br>
<br>
This was casuing my release+asserts build on Windows to fail.<br></blockquote><div><br></div><div>I think Debug.h practically depends on raw_ostream.h. Including only Debug.h won't raise a compilation error, but you cannot do anything (like writing something with <<) to raw_ostream objects returned from llvm::dbgs() or llvm::err() without the header. Should we include raw_ostream.h from Debug.h?</div>

<div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
Modified:<br>
    llvm/trunk/lib/Target/R600/SIFixSGPRCopies.cpp<br>
<br>
Modified: llvm/trunk/lib/Target/R600/SIFixSGPRCopies.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/R600/SIFixSGPRCopies.cpp?rev=194747&r1=194746&r2=194747&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/R600/SIFixSGPRCopies.cpp?rev=194747&r1=194746&r2=194747&view=diff</a><br>


==============================================================================<br>
--- llvm/trunk/lib/Target/R600/SIFixSGPRCopies.cpp (original)<br>
+++ llvm/trunk/lib/Target/R600/SIFixSGPRCopies.cpp Thu Nov 14 17:24:09 2013<br>
@@ -72,6 +72,7 @@<br>
 #include "llvm/CodeGen/MachineInstrBuilder.h"<br>
 #include "llvm/CodeGen/MachineRegisterInfo.h"<br>
 #include "llvm/Support/Debug.h"<br>
+#include "llvm/Support/raw_ostream.h"<br>
 #include "llvm/Target/TargetMachine.h"<br>
<br>
 using namespace llvm;<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div></div>