<html><head><meta http-equiv="Content-Type" content="text/html charset=iso-8859-1"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><br><div><div>On Nov 14, 2013, at 6:57 PM, Rui Ueyama <<a href="mailto:ruiu@google.com">ruiu@google.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Thu, Nov 14, 2013 at 6:41 PM, <a href="mailto:kledzik@apple.com">kledzik@apple.com</a> <span dir="ltr"><<a href="mailto:kledzik@apple.com" target="_blank">kledzik@apple.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br>
<br>
================<br>
Comment at: lib/Core/SymbolTable.cpp:192-194<br>
@@ +191,5 @@<br>
<div class="im">+ const UndefinedAtom *newFallback = newUndef->fallback();<br>
</div><div class="im">+ bool hasDifferentFallback =<br>
+ (existingFallback && newFallback &&<br>
</div>+ existingFallback->name() != newFallback->name());<br>
+ if (hasDifferentFallback) {<br>
----------------<br>
hasDifferentFallback should also be true if one has a fallback and the other does not.<br></blockquote><div><br></div><div>If the existing atom does not have a fallback and new one has, it's normal -- no need to warn that. So the condition would be a bit complicated that.</div>
</div></div></div>
</blockquote></div>Ah! If one has a fallback and the other does not, you always silently choose the one with a fallback. The only time you need a warning is when both define fallbacks but they are different.<div><br></div><div>LGTM.</div><div><br></div><div>-Nick</div><div><br></div><div><br></div></body></html>