<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;">The functions in the file are documented without \brief and it is better to be consistent. <div><br><div><div>On Nov 13, 2013, at 3:17 PM, Robinson, Paul <<a href="mailto:Paul_Robinson@playstation.sony.com">Paul_Robinson@playstation.sony.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div style="font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><blockquote type="cite">-----Original Message-----<br>From:<span class="Apple-converted-space"> </span><a href="mailto:llvm-commits-bounces@cs.uiuc.edu">llvm-commits-bounces@cs.uiuc.edu</a><span class="Apple-converted-space"> </span>[mailto:llvm-commits-<br><a href="mailto:bounces@cs.uiuc.edu">bounces@cs.uiuc.edu</a>] On Behalf Of Nadav Rotem<br>Sent: Tuesday, November 12, 2013 5:12 PM<br>To:<span class="Apple-converted-space"> </span><a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>Subject: [llvm] r194537 - Update the docs to match the function name.<br><br>Author: nadav<br>Date: Tue Nov 12 19:12:01 2013<br>New Revision: 194537<br><br>URL: <a href="http://llvm.org/viewvc/llvm-project?rev=194537&view=rev">http://llvm.org/viewvc/llvm-project?rev=194537&view=rev</a><br>Log:<br>Update the docs to match the function name.<br><br>Modified:<br> llvm/trunk/lib/Transforms/InstCombine/InstCombineAndOrXor.cpp<br><br>Modified: llvm/trunk/lib/Transforms/InstCombine/InstCombineAndOrXor.cpp<br>URL: <a href="http://llvm.org/viewvc/llvm-">http://llvm.org/viewvc/llvm-</a><br>project/llvm/trunk/lib/Transforms/InstCombine/InstCombineAndOrXor.cpp?re<br>v=194537&r1=194536&r2=194537&view=diff<br>========================================================================<br>======<br>--- llvm/trunk/lib/Transforms/InstCombine/InstCombineAndOrXor.cpp<br>(original)<br>+++ llvm/trunk/lib/Transforms/InstCombine/InstCombineAndOrXor.cpp Tue<br>Nov 12 19:12:01 2013<br>@@ -1543,7 +1543,7 @@ static Instruction *MatchSelectFromAndOr<br> return 0;<br>}<br><br>-/// IsSingleBitValue - Returns true for "one-hot" values (values where<br>at most<br>+/// IsOneHotValue - Returns true for "one-hot" values (values where at<br>most<br></blockquote><br>Use \brief instead?<br><br><blockquote type="cite">/// one bit can be set).<br>static bool IsOneHotValue(Value *V) {<br> // Match 1<<K.<br><br><br>_______________________________________________<br>llvm-commits mailing list<br><a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br><a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a></blockquote></div></blockquote></div><br></div></body></html>