<div dir="ltr">+kcc</div><div class="gmail_extra"><br><br><div class="gmail_quote">On Wed, Nov 13, 2013 at 6:41 AM, Shankar Easwaran <span dir="ltr"><<a href="mailto:shankare@codeaurora.org" target="_blank">shankare@codeaurora.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Sorry for another indirection. Rick foos is working on it. I think there is some good news here :)<br>
<br>
Cced Rick + adding Galina,Dmitri.<br>
<br>
Thanks<br>
<br>
Shankar Easwaran<div class="HOEnZb"><div class="h5"><br>
<br>
On 11/12/2013 8:37 PM, Rui Ueyama wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Shankar tried to set it up recently.<br>
<br>
<br>
On Tue, Nov 12, 2013 at 6:31 PM, Sean Silva <<a href="mailto:silvas@purdue.edu" target="_blank">silvas@purdue.edu</a>> wrote:<br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Sanitizers?<br>
<br>
There have been a couple of these sorts of bugs recently... we really<br>
ought to have some sanitizer bots...<br>
<br>
-- Sean Silva<br>
<br>
<br>
On Tue, Nov 12, 2013 at 9:21 PM, Rui Ueyama <<a href="mailto:ruiu@google.com" target="_blank">ruiu@google.com</a>> wrote:<br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Author: ruiu<br>
Date: Tue Nov 12 20:21:51 2013<br>
New Revision: 194545<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=194545&view=rev" target="_blank">http://llvm.org/viewvc/llvm-<u></u>project?rev=194545&view=rev</a><br>
Log:<br>
[PECOFF] Fix use-after-return.<br>
<br>
Modified:<br>
lld/trunk/lib/Driver/<u></u>WinLinkDriver.cpp<br>
<br>
Modified: lld/trunk/lib/Driver/<u></u>WinLinkDriver.cpp<br>
URL:<br>
<a href="http://llvm.org/viewvc/llvm-project/lld/trunk/lib/Driver/WinLinkDriver.cpp?rev=194545&r1=194544&r2=194545&view=diff" target="_blank">http://llvm.org/viewvc/llvm-<u></u>project/lld/trunk/lib/Driver/<u></u>WinLinkDriver.cpp?rev=194545&<u></u>r1=194544&r2=194545&view=diff</a><br>
<br>
==============================<u></u>==============================<u></u>==================<br>
--- lld/trunk/lib/Driver/<u></u>WinLinkDriver.cpp (original)<br>
+++ lld/trunk/lib/Driver/<u></u>WinLinkDriver.cpp Tue Nov 12 20:21:51 2013<br>
@@ -842,7 +842,7 @@ WinLinkDriver::parse(int argc, const cha<br>
<br>
case OPT_INPUT:<br>
inputElements.push_back(std::<u></u>unique_ptr<InputElement>(<br>
- new PECOFFFileNode(ctx, inputArg->getValue())));<br>
+ new PECOFFFileNode(ctx,<br>
ctx.allocateString(inputArg-><u></u>getValue()))));<br>
break;<br>
<br>
#define DEFINE_BOOLEAN_FLAG(name, setter) \<br>
@@ -892,9 +892,11 @@ WinLinkDriver::parse(int argc, const cha<br>
// start with a hypen or a slash. This is not compatible with link.exe<br>
// but useful for us to test lld on Unix.<br>
if (llvm::opt::Arg *dashdash = parsedArgs->getLastArg(OPT_<u></u>DASH_DASH)) {<br>
- for (const StringRef value : dashdash->getValues())<br>
- inputElements.push_back(<br>
- std::unique_ptr<InputElement>(<u></u>new PECOFFFileNode(ctx, value)));<br>
+ for (const StringRef value : dashdash->getValues()) {<br>
+ std::unique_ptr<InputElement> elem(<br>
+ new PECOFFFileNode(ctx, ctx.allocateString(value)));<br>
+ inputElements.push_back(std::<u></u>move(elem));<br>
+ }<br>
}<br>
<br>
// Add the libraries specified by /defaultlib unless they are already<br>
added<br>
<br>
<br>
______________________________<u></u>_________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/<u></u>mailman/listinfo/llvm-commits</a><br>
<br>
</blockquote>
<br>
</blockquote></blockquote>
<br>
<br></div></div><span class="HOEnZb"><font color="#888888">
-- <br>
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by the Linux Foundation</font></span><div class="HOEnZb"><div class="h5"><br>
<br>
______________________________<u></u>_________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/<u></u>mailman/listinfo/llvm-commits</a><br>
</div></div></blockquote></div><br></div>