<div dir="ltr"><br><div class="gmail_extra"><br><br><div class="gmail_quote">On Tue, Nov 12, 2013 at 7:17 PM, Nick Kledzik <span dir="ltr"><<a href="mailto:kledzik@apple.com" target="_blank">kledzik@apple.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="HOEnZb"><div class="h5"><br>
On Nov 12, 2013, at 7:09 PM, Rui Ueyama <<a href="mailto:ruiu@google.com">ruiu@google.com</a>> wrote:<br>
<br>
> Author: ruiu<br>
> Date: Tue Nov 12 21:09:20 2013<br>
> New Revision: 194551<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=194551&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=194551&view=rev</a><br>
> Log:<br>
> Use empty() instead of size() == 0.<br>
><br>
> Modified:<br>
>    lld/trunk/lib/Core/Resolver.cpp<br>
>    lld/trunk/lib/Driver/InputGraph.cpp<br>
>    lld/trunk/lib/Driver/WinLinkDriver.cpp<br>
>    lld/trunk/lib/ReaderWriter/ELF/SectionChunks.h<br>
>    lld/trunk/lib/ReaderWriter/MachO/StubsPass.hpp<br>
>    lld/trunk/lib/ReaderWriter/PECOFF/ReaderCOFF.cpp<br>
><br>
> Modified: lld/trunk/lib/Core/Resolver.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/lib/Core/Resolver.cpp?rev=194551&r1=194550&r2=194551&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/lld/trunk/lib/Core/Resolver.cpp?rev=194551&r1=194550&r2=194551&view=diff</a><br>

> ==============================================================================<br>
> --- lld/trunk/lib/Core/Resolver.cpp (original)<br>
> +++ lld/trunk/lib/Core/Resolver.cpp Tue Nov 12 21:09:20 2013<br>
> @@ -227,7 +227,7 @@ void Resolver::doDefinedAtom(const Defin<br>
>   switch ( atom.sectionPosition() ) {<br>
>   case DefinedAtom::sectionPositionStart:<br>
>   case DefinedAtom::sectionPositionEnd:<br>
> -    assert(atom.size() == 0);<br>
> +    assert(atom.empty());<br>
>     break;<br>
</div></div>Atoms are not containers.  There is no empty() method, just a size() method.  This breaks the build.<br></blockquote><div><br></div><div>My fault - I just assumed it was an ArrayRef or container, etc. An empty function's probably a nice thing to add, though.</div>
<div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<span class="HOEnZb"><font color="#888888"><br>
-Nick<br>
</font></span><div class="HOEnZb"><div class="h5"><br>
<br>
<br>
>   case DefinedAtom::sectionPositionEarly:<br>
>   case DefinedAtom::sectionPositionAny:<br>
><br>
> Modified: lld/trunk/lib/Driver/InputGraph.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/lib/Driver/InputGraph.cpp?rev=194551&r1=194550&r2=194551&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/lld/trunk/lib/Driver/InputGraph.cpp?rev=194551&r1=194550&r2=194551&view=diff</a><br>

> ==============================================================================<br>
> --- lld/trunk/lib/Driver/InputGraph.cpp (original)<br>
> +++ lld/trunk/lib/Driver/InputGraph.cpp Tue Nov 12 21:09:20 2013<br>
> @@ -133,7 +133,7 @@ uint32_t ControlNode::getResolveState()<br>
> /// \brief Set the resolve state for the current element<br>
> /// thats processed by the resolver.<br>
> void ControlNode::setResolveState(uint32_t resolveState) {<br>
> -  if (_elements.size() == 0)<br>
> +  if (_elements.empty())<br>
>     return;<br>
>   _elements[_currentElementIndex]->setResolveState(resolveState);<br>
> }<br>
> @@ -151,7 +151,7 @@ SimpleFileNode::SimpleFileNode(StringRef<br>
> /// of the input elements contained in the group.<br>
> ErrorOr<File &> Group::getNextFile() {<br>
>   // If there are no elements, move on to the next input element<br>
> -  if (_elements.size() == 0)<br>
> +  if (_elements.empty())<br>
>     return make_error_code(InputGraphError::no_more_files);<br>
><br>
>   for (;;) {<br>
><br>
> Modified: lld/trunk/lib/Driver/WinLinkDriver.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/lib/Driver/WinLinkDriver.cpp?rev=194551&r1=194550&r2=194551&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/lld/trunk/lib/Driver/WinLinkDriver.cpp?rev=194551&r1=194550&r2=194551&view=diff</a><br>

> ==============================================================================<br>
> --- lld/trunk/lib/Driver/WinLinkDriver.cpp (original)<br>
> +++ lld/trunk/lib/Driver/WinLinkDriver.cpp Tue Nov 12 21:09:20 2013<br>
> @@ -911,7 +911,7 @@ WinLinkDriver::parse(int argc, const cha<br>
>     }<br>
>   }<br>
><br>
> -  if (inputElements.size() == 0 && !isReadingDirectiveSection) {<br>
> +  if (inputElements.empty() && !isReadingDirectiveSection) {<br>
>     diagnostics << "No input files\n";<br>
>     return false;<br>
>   }<br>
><br>
> Modified: lld/trunk/lib/ReaderWriter/ELF/SectionChunks.h<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/ELF/SectionChunks.h?rev=194551&r1=194550&r2=194551&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/ELF/SectionChunks.h?rev=194551&r1=194550&r2=194551&view=diff</a><br>

> ==============================================================================<br>
> --- lld/trunk/lib/ReaderWriter/ELF/SectionChunks.h (original)<br>
> +++ lld/trunk/lib/ReaderWriter/ELF/SectionChunks.h Tue Nov 12 21:09:20 2013<br>
> @@ -576,7 +576,7 @@ StringTable<ELFT>::StringTable(const ELF<br>
><br>
> template <class ELFT> uint64_t StringTable<ELFT>::addString(StringRef symname) {<br>
><br>
> -  if (symname.size() == 0)<br>
> +  if (symname.empty())<br>
>     return 0;<br>
>   StringMapTIter stringIter = _stringMap.find(symname);<br>
>   if (stringIter == _stringMap.end()) {<br>
><br>
> Modified: lld/trunk/lib/ReaderWriter/MachO/StubsPass.hpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/MachO/StubsPass.hpp?rev=194551&r1=194550&r2=194551&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/MachO/StubsPass.hpp?rev=194551&r1=194550&r2=194551&view=diff</a><br>

> ==============================================================================<br>
> --- lld/trunk/lib/ReaderWriter/MachO/StubsPass.hpp (original)<br>
> +++ lld/trunk/lib/ReaderWriter/MachO/StubsPass.hpp Tue Nov 12 21:09:20 2013<br>
> @@ -123,7 +123,7 @@ public:<br>
><br>
>   virtual void addStubAtoms(MutableFile &mergedFile) {<br>
>     // Exit early if no stubs needed.<br>
> -    if ( _targetToStub.size() == 0 )<br>
> +    if (_targetToStub.empty())<br>
>       return;<br>
>     // Add all stubs to master file.<br>
>     for (auto it : _targetToStub) {<br>
><br>
> Modified: lld/trunk/lib/ReaderWriter/PECOFF/ReaderCOFF.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/PECOFF/ReaderCOFF.cpp?rev=194551&r1=194550&r2=194551&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/PECOFF/ReaderCOFF.cpp?rev=194551&r1=194550&r2=194551&view=diff</a><br>

> ==============================================================================<br>
> --- lld/trunk/lib/ReaderWriter/PECOFF/ReaderCOFF.cpp (original)<br>
> +++ lld/trunk/lib/ReaderWriter/PECOFF/ReaderCOFF.cpp Tue Nov 12 21:09:20 2013<br>
> @@ -666,7 +666,7 @@ private:<br>
>       array = array.slice(3);<br>
>     }<br>
><br>
> -    if (array.size() == 0)<br>
> +    if (array.empty())<br>
>       return "";<br>
><br>
>     size_t len = 0;<br>
><br>
><br>
> _______________________________________________<br>
> llvm-commits mailing list<br>
> <a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</div></div></blockquote></div><br></div></div>