<div dir="ltr">Hi Weiming,<div><br></div><div>Looks good. A few comments:<br><div><br></div><div><div>+              clEnumValN(NoRestrictedIT, "arm-no-restrict-it",</div><div>+                         "Allow IT blocks of ARMv7"),</div>
</div><div><br></div><div>typo "on ARMv7".</div><div><br></div><div><div>+static cl::opt<bool> DisableUseMOVT("arm-disable-use-movt", cl::init(false),</div><div>+                                    cl::Hidden, cl::ZeroOrMore);</div>
</div><div><br></div><div>I wouldn't change this. Try to make it as it was, so that the change log doesn't blame you for anything. ;)</div><div><br></div><div>thanks,</div><div>--renato</div><div><br></div><div><br>
</div></div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On 12 November 2013 01:38, Weiming Zhao <span dir="ltr"><<a href="mailto:weimingz@codeaurora.org" target="_blank">weimingz@codeaurora.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div lang="EN-US" link="blue" vlink="purple"><div><p class="MsoNormal">Hi,<u></u><u></u></p><p class="MsoNormal"><u></u> <u></u></p>
<p class="MsoNormal">AArch32 allows Thumbv7 IT blocks to be executed for backward compatibility.<u></u><u></u></p><p class="MsoNormal">GCC has a  “-mno-restrict-it” flag.    <a href="http://gcc.gnu.org/ml/gcc-patches/2013-06/msg00164.html" target="_blank">http://gcc.gnu.org/ml/gcc-patches/2013-06/msg00164.html</a><u></u><u></u></p>
<p class="MsoNormal">Attached are the patches for llvm and clang that provides similar functionality.<u></u><u></u></p><p class="MsoNormal"><u></u> <u></u></p><p class="MsoNormal">Please help to review them.<u></u><u></u></p>
<p class="MsoNormal"><u></u> <u></u></p><p class="MsoNormal">Thanks,<u></u><u></u></p><p class="MsoNormal">Weiming<u></u><u></u></p><p class="MsoNormal"><u></u> <u></u></p><p class="MsoNormal"><u></u> <u></u></p><p class="MsoNormal">
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation<u></u><u></u></p><p class="MsoNormal"><u></u> <u></u></p></div></div><br>_______________________________________________<br>

llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
<br></blockquote></div><br></div>