<div dir="ltr">I intentionally left the braces because of the comments. It seems alarming if there are two lines indented to the same column after "if", as it looks like the second line is misaligned. In this case, the first line is comment, so it'd actually not a problem, but it would have been a bit surprise at first sight.<br>

<div class="gmail_extra">
<br></div><div class="gmail_extra"><div class="gmail_quote">On Tue, Nov 12, 2013 at 10:13 AM, Shankar Easwaran <span dir="ltr"><<a href="mailto:shankare@codeaurora.org" target="_blank">shankare@codeaurora.org</a>></span> wrote:<br>



<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Single block if-statement is containining braces. You might want to remove the braces :)<br>
<br>
Does clang-format detect it and remove it ? any idea ?<div><div><br>
<br>
On 11/12/2013 11:46 AM, Rui Ueyama wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Author: ruiu<br>
Date: Tue Nov 12 11:46:55 2013<br>
New Revision: 194492<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=194492&view=rev" target="_blank">http://llvm.org/viewvc/llvm-<u></u>project?rev=194492&view=rev</a><br>
Log:<br>
[MachO] Simplify conditionals. No functionality change.<br>
<br>
Modified:<br>
     lld/trunk/lib/ReaderWriter/<u></u>MachO/MachOLinkingContext.cpp<br>
<br>
Modified: lld/trunk/lib/ReaderWriter/<u></u>MachO/MachOLinkingContext.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/MachO/MachOLinkingContext.cpp?rev=194492&r1=194491&r2=194492&view=diff" target="_blank">http://llvm.org/viewvc/llvm-<u></u>project/lld/trunk/lib/<u></u>ReaderWriter/MachO/<u></u>MachOLinkingContext.cpp?rev=<u></u>194492&r1=194491&r2=194492&<u></u>view=diff</a><br>




==============================<u></u>==============================<u></u>==================<br>
--- lld/trunk/lib/ReaderWriter/<u></u>MachO/MachOLinkingContext.cpp (original)<br>
+++ lld/trunk/lib/ReaderWriter/<u></u>MachO/MachOLinkingContext.cpp Tue Nov 12 11:46:55 2013<br>
@@ -221,14 +221,12 @@ bool MachOLinkingContext::<u></u>validateImpl(r<br>
    if ((_outputFileType == MH_EXECUTE) && _entrySymbolName.empty()){<br>
      if (_outputFileTypeStatic) {<br>
        _entrySymbolName = "start";<br>
-    } else {<br>
-      // If targeting newer OS, use _main<br>
-      if (addEntryPointLoadCommand())<br>
-        _entrySymbolName = "_main";<br>
-<br>
+    } else if (addUnixThreadLoadCommand()) {<br>
        // If targeting older OS, use start (in crt1.o)<br>
-      if (addUnixThreadLoadCommand())<br>
-        _entrySymbolName = "start";<br>
+      _entrySymbolName = "start";<br>
+    } else if (addEntryPointLoadCommand()) {<br>
+      // If targeting newer OS, use _main<br>
+      _entrySymbolName = "_main";<br>
      }<br>
    }<br>
  <br>
<br>
______________________________<u></u>_________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/<u></u>mailman/listinfo/llvm-commits</a><br>
<br>
<br>
</blockquote>
<br>
<br></div></div><span><font color="#888888">
-- <br>
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by the Linux Foundation<br>
<br>
</font></span></blockquote></div><br></div></div>