<div dir="ltr">Sanitizers?<div><br></div><div>There have been a couple of these sorts of bugs recently... we really ought to have some sanitizer bots...</div><div><br></div><div>-- Sean Silva</div></div><div class="gmail_extra">
<br><br><div class="gmail_quote">On Tue, Nov 12, 2013 at 9:21 PM, Rui Ueyama <span dir="ltr"><<a href="mailto:ruiu@google.com" target="_blank">ruiu@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Author: ruiu<br>
Date: Tue Nov 12 20:21:51 2013<br>
New Revision: 194545<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=194545&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=194545&view=rev</a><br>
Log:<br>
[PECOFF] Fix use-after-return.<br>
<br>
Modified:<br>
    lld/trunk/lib/Driver/WinLinkDriver.cpp<br>
<br>
Modified: lld/trunk/lib/Driver/WinLinkDriver.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/lib/Driver/WinLinkDriver.cpp?rev=194545&r1=194544&r2=194545&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/lld/trunk/lib/Driver/WinLinkDriver.cpp?rev=194545&r1=194544&r2=194545&view=diff</a><br>

==============================================================================<br>
--- lld/trunk/lib/Driver/WinLinkDriver.cpp (original)<br>
+++ lld/trunk/lib/Driver/WinLinkDriver.cpp Tue Nov 12 20:21:51 2013<br>
@@ -842,7 +842,7 @@ WinLinkDriver::parse(int argc, const cha<br>
<br>
     case OPT_INPUT:<br>
       inputElements.push_back(std::unique_ptr<InputElement>(<br>
-          new PECOFFFileNode(ctx, inputArg->getValue())));<br>
+          new PECOFFFileNode(ctx, ctx.allocateString(inputArg->getValue()))));<br>
       break;<br>
<br>
 #define DEFINE_BOOLEAN_FLAG(name, setter)       \<br>
@@ -892,9 +892,11 @@ WinLinkDriver::parse(int argc, const cha<br>
   // start with a hypen or a slash. This is not compatible with link.exe<br>
   // but useful for us to test lld on Unix.<br>
   if (llvm::opt::Arg *dashdash = parsedArgs->getLastArg(OPT_DASH_DASH)) {<br>
-    for (const StringRef value : dashdash->getValues())<br>
-      inputElements.push_back(<br>
-          std::unique_ptr<InputElement>(new PECOFFFileNode(ctx, value)));<br>
+    for (const StringRef value : dashdash->getValues()) {<br>
+      std::unique_ptr<InputElement> elem(<br>
+          new PECOFFFileNode(ctx, ctx.allocateString(value)));<br>
+      inputElements.push_back(std::move(elem));<br>
+    }<br>
   }<br>
<br>
   // Add the libraries specified by /defaultlib unless they are already added<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div>