<html>
<head>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<div class="moz-cite-prefix">On 11/06/2013 09:07 AM, Rafael
Espíndola wrote:<br>
</div>
<blockquote
cite="mid:CAG3jReL+aaG5Q_RX5Vox+StY1sZ6J1WXkEX1Y0SjrJ+nHgPYkw@mail.gmail.com"
type="cite">
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
Test case?<br>
<br>
</blockquote>
I'm open to suggestions for "make check" test cases for this
constant island stuff.<br>
<br>
I can make them easily but they will be huge. You need a large
program to trigger some of these cases.<br>
Then people will complain about having all these giant bit code
files that they have to compile whenever<br>
they run "make check".<br>
<br>
Right now I am forcing the situations I want with hidden developer
only command line paramaters so that the<br>
test cases for the main logic can be and understandable.<br>
<br>
Well perhaps these is some kind of bit code that can be used to emit
an inline array of words in place of instructions<br>
or something. So that one bit code statement makes a 65k hole.<br>
<br>
Reed<br>
<br>
<blockquote
cite="mid:CAG3jReL+aaG5Q_RX5Vox+StY1sZ6J1WXkEX1Y0SjrJ+nHgPYkw@mail.gmail.com"
type="cite">On Tuesday, November 5, 2013, Reed Kotler wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">Author:
rkotler<br>
Date: Tue Nov 5 22:29:52 2013<br>
New Revision: 194126<br>
<br>
URL: <a moz-do-not-send="true"
href="http://llvm.org/viewvc/llvm-project?rev=194126&view=rev"
target="_blank">http://llvm.org/viewvc/llvm-project?rev=194126&view=rev</a><br>
Log:<br>
Fix definition for Mips16 pc relative load word instructions.<br>
<br>
<br>
Modified:<br>
llvm/trunk/lib/Target/Mips/MipsConstantIslandPass.cpp<br>
<br>
Modified: llvm/trunk/lib/Target/Mips/MipsConstantIslandPass.cpp<br>
URL: <a moz-do-not-send="true"
href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/Mips/MipsConstantIslandPass.cpp?rev=194126&r1=194125&r2=194126&view=diff"
target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/Mips/MipsConstantIslandPass.cpp?rev=194126&r1=194125&r2=194126&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/lib/Target/Mips/MipsConstantIslandPass.cpp
(original)<br>
+++ llvm/trunk/lib/Target/Mips/MipsConstantIslandPass.cpp Tue
Nov 5 22:29:52 2013<br>
@@ -614,12 +614,13 @@ initializeFunctionInfo(const std::vector<br>
llvm_unreachable("Unknown addressing mode for CP
reference!");<br>
case Mips::LwRxPcTcp16:<br>
Bits = 8;<br>
- Scale = 2;<br>
+ Scale = 4;<br>
LongFormOpcode = Mips::LwRxPcTcpX16;<br>
break;<br>
case Mips::LwRxPcTcpX16:<br>
Bits = 16;<br>
- Scale = 2;<br>
+ Scale = 1;<br>
+ NegOk = true;<br>
break;<br>
}<br>
// Remember that this is a user of a CP entry.<br>
@@ -782,9 +783,6 @@ MachineBasicBlock *MipsConstantIslands::<br>
/// isOffsetInRange - Checks whether UserOffset (the location
of a constant pool<br>
/// reference) is within MaxDisp of TrialOffset (a proposed
location of a<br>
/// constant pool entry).<br>
-/// UserOffset is computed by getUserOffset above to include PC
adjustments. If<br>
-/// the mod 4 alignment of UserOffset is not known, the
uncertainty must be<br>
-/// subtracted from MaxDisp instead. CPUser::getMaxDisp() does
that.<br>
bool MipsConstantIslands::isOffsetInRange(unsigned UserOffset,<br>
unsigned TrialOffset,
unsigned MaxDisp,<br>
bool NegativeOK) {<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a moz-do-not-send="true" href="javascript:;" onclick="_e(event,
'cvml', 'llvm-commits@cs.uiuc.edu')">llvm-commits@cs.uiuc.edu</a><br>
<a moz-do-not-send="true"
href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits"
target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote>
</blockquote>
<br>
</body>
</html>