Test case?<br><br>On Tuesday, November 5, 2013, Reed Kotler  wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: rkotler<br>
Date: Tue Nov  5 22:29:52 2013<br>
New Revision: 194126<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=194126&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=194126&view=rev</a><br>
Log:<br>
Fix definition for Mips16 pc relative load word instructions.<br>
<br>
<br>
Modified:<br>
    llvm/trunk/lib/Target/Mips/MipsConstantIslandPass.cpp<br>
<br>
Modified: llvm/trunk/lib/Target/Mips/MipsConstantIslandPass.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/Mips/MipsConstantIslandPass.cpp?rev=194126&r1=194125&r2=194126&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/Mips/MipsConstantIslandPass.cpp?rev=194126&r1=194125&r2=194126&view=diff</a><br>

==============================================================================<br>
--- llvm/trunk/lib/Target/Mips/MipsConstantIslandPass.cpp (original)<br>
+++ llvm/trunk/lib/Target/Mips/MipsConstantIslandPass.cpp Tue Nov  5 22:29:52 2013<br>
@@ -614,12 +614,13 @@ initializeFunctionInfo(const std::vector<br>
             llvm_unreachable("Unknown addressing mode for CP reference!");<br>
           case Mips::LwRxPcTcp16:<br>
             Bits = 8;<br>
-            Scale = 2;<br>
+            Scale = 4;<br>
             LongFormOpcode = Mips::LwRxPcTcpX16;<br>
             break;<br>
           case Mips::LwRxPcTcpX16:<br>
             Bits = 16;<br>
-            Scale = 2;<br>
+            Scale = 1;<br>
+            NegOk = true;<br>
             break;<br>
           }<br>
           // Remember that this is a user of a CP entry.<br>
@@ -782,9 +783,6 @@ MachineBasicBlock *MipsConstantIslands::<br>
 /// isOffsetInRange - Checks whether UserOffset (the location of a constant pool<br>
 /// reference) is within MaxDisp of TrialOffset (a proposed location of a<br>
 /// constant pool entry).<br>
-/// UserOffset is computed by getUserOffset above to include PC adjustments. If<br>
-/// the mod 4 alignment of UserOffset is not known, the uncertainty must be<br>
-/// subtracted from MaxDisp instead. CPUser::getMaxDisp() does that.<br>
 bool MipsConstantIslands::isOffsetInRange(unsigned UserOffset,<br>
                                          unsigned TrialOffset, unsigned MaxDisp,<br>
                                          bool NegativeOK) {<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="javascript:;" onclick="_e(event, 'cvml', 'llvm-commits@cs.uiuc.edu')">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote>