<div dir="ltr">I replaced #ifdef FIXME with #ifndef NDEBUG in Driver.cpp and remove all calls of pm.add() from each flavor's LinkerContext classes. All tests but only one succeeded. The log of the failing test is this. Do you have any idea what was going on?<div>
<div><br></div></div><blockquote style="margin:0 0 0 40px;border:none;padding:0px"><div><div><div><div><font face="courier new, monospace">Exit Code: 1</font></div></div></div></div><div><div><div><div><font face="courier new, monospace"><br>
</font></div></div></div></div><div><div><div><div><font face="courier new, monospace">Command Output (stderr):</font></div></div></div></div><div><div><div><div><font face="courier new, monospace">--</font></div></div></div>
</div><div><div><div><div><font face="courier new, monospace">Name : /usr/local/google/home/ruiu/src/llvm/tools/lld/test/elf/Inputs/foo.o.x86-64</font></div></div></div></div><div><div><div><div><font face="courier new, monospace">Type : ELF File</font></div>
</div></div></div><div><div><div><div><font face="courier new, monospace">Ordinal : 0</font></div></div></div></div><div><div><div><div><font face="courier new, monospace">Attributes : </font></div></div></div></div><div>
<div><div><div><font face="courier new, monospace"> - wholeArchive : false</font></div></div></div></div><div><div><div><div><font face="courier new, monospace"> - asNeeded : false</font></div></div></div></div><div><div>
<div><div><font face="courier new, monospace"> contextPath : None</font></div></div></div></div><div><div><div><div><font face="courier new, monospace">Undefined Symbol: command line option -entry : _start</font></div></div>
</div></div><div><div><div><div><font face="courier new, monospace">symbol(s) not found</font></div></div></div></div><div><div><div><div><font face="courier new, monospace">/usr/local/google/home/ruiu/src/llvm/tools/lld/test/elf/roundtrip.test:10:7: error: expected string not found in input</font></div>
</div></div></div><div><div><div><div><font face="courier new, monospace">CHECK:path:{{.*}}.native</font></div></div></div></div><div><div><div><div><font face="courier new, monospace"> ^</font></div></div></div></div>
<div><div><div><div><font face="courier new, monospace"><stdin>:1:1: note: scanning from here</font></div></div></div></div><div><div><div><div><font face="courier new, monospace">---</font></div></div></div></div>
<div>
<div><div><div><font face="courier new, monospace">^</font></div></div></div></div><div><div><div><div><font face="courier new, monospace"><stdin>:2:1: note: possible intended match here</font></div></div></div></div>
<div><div><div><div><font face="courier new, monospace">path: ''</font></div></div></div></div><div><div><div><div><font face="courier new, monospace">^</font></div></div></div></div><div><div><div><div><font face="courier new, monospace"><br>
</font></div></div></div></div><div><div><div><div><font face="courier new, monospace">--</font></div></div></div></div><div><div><div><div><font face="courier new, monospace"><br></font></div></div></div></div><div><div>
<div><div><font face="courier new, monospace">********************</font></div></div></div></div><div><div><div><div><font face="courier new, monospace">Testing: 0 .. 10.. 20.. 30.. 40.. 50.. 60.. 70.. 80.. 90.. </font></div>
</div></div></div><div><div><div><div><font face="courier new, monospace">Testing Time: 0.63s</font></div></div></div></div><div><div><div><div><font face="courier new, monospace">********************</font></div></div></div>
</div><div><div><div><div><font face="courier new, monospace">Failing Tests (1):</font></div></div></div></div><div><div><div><div><font face="courier new, monospace"> lld :: elf/roundtrip.test</font></div></div></div>
</div></blockquote><div><div><div><br></div><div><font face="courier new, monospace"><br></font></div><div><font face="courier new, monospace">--</font></div></div><div><br></div></div></div><div class="gmail_extra"><br>
<br>
<div class="gmail_quote">On Fri, Nov 1, 2013 at 1:12 PM, Shankar Easwaran <span dir="ltr"><<a href="mailto:shankare@codeaurora.org" target="_blank">shankare@codeaurora.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Thanks for working and enabling this.<div class="HOEnZb"><div class="h5"><br>
<br>
On 11/1/2013 2:52 PM, Rui Ueyama wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Author: ruiu<br>
Date: Fri Nov 1 14:52:37 2013<br>
New Revision: 193881<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=193881&view=rev" target="_blank">http://llvm.org/viewvc/llvm-<u></u>project?rev=193881&view=rev</a><br>
Log:<br>
[PECOFF] Enable RoundTrip{YAML,Native}Pass.<br>
<br>
Modified:<br>
lld/trunk/lib/ReaderWriter/<u></u>PECOFF/PECOFFLinkingContext.<u></u>cpp<br>
<br>
Modified: lld/trunk/lib/ReaderWriter/<u></u>PECOFF/PECOFFLinkingContext.<u></u>cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/PECOFF/PECOFFLinkingContext.cpp?rev=193881&r1=193880&r2=193881&view=diff" target="_blank">http://llvm.org/viewvc/llvm-<u></u>project/lld/trunk/lib/<u></u>ReaderWriter/PECOFF/<u></u>PECOFFLinkingContext.cpp?rev=<u></u>193881&r1=193880&r2=193881&<u></u>view=diff</a><br>
==============================<u></u>==============================<u></u>==================<br>
--- lld/trunk/lib/ReaderWriter/<u></u>PECOFF/PECOFFLinkingContext.<u></u>cpp (original)<br>
+++ lld/trunk/lib/ReaderWriter/<u></u>PECOFF/PECOFFLinkingContext.<u></u>cpp Fri Nov 1 14:52:37 2013<br>
@@ -12,15 +12,17 @@<br>
#include "IdataPass.h"<br>
#include "LinkerGeneratedSymbolFile.h"<br>
-#include "llvm/ADT/SmallString.h"<br>
-#include "llvm/Support/Allocator.h"<br>
-#include "llvm/Support/Path.h"<br>
#include "lld/Core/PassManager.h"<br>
#include "lld/Passes/LayoutPass.h"<br>
+#include "lld/Passes/<u></u>RoundTripNativePass.h"<br>
+#include "lld/Passes/RoundTripYAMLPass.<u></u>h"<br>
#include "lld/ReaderWriter/<u></u>PECOFFLinkingContext.h"<br>
#include "lld/ReaderWriter/Reader.h"<br>
#include "lld/ReaderWriter/Simple.h"<br>
#include "lld/ReaderWriter/Writer.h"<br>
+#include "llvm/ADT/SmallString.h"<br>
+#include "llvm/Support/Allocator.h"<br>
+#include "llvm/Support/Path.h"<br>
#include <bitset><br>
#include <set><br>
@@ -208,5 +210,9 @@ void PECOFFLinkingContext::<u></u>addPasses(Pas<br>
pm.add(std::unique_ptr<Pass>(<u></u>new pecoff::GroupedSectionsPass())<u></u>);<br>
pm.add(std::unique_ptr<Pass>(<u></u>new pecoff::IdataPass(*this)));<br>
pm.add(std::unique_ptr<Pass>(<u></u>new LayoutPass()));<br>
+#ifndef NDEBUG<br>
+ pm.add(std::unique_ptr<Pass>(<u></u>new RoundTripYAMLPass(*this)));<br>
+ pm.add(std::unique_ptr<Pass>(<u></u>new RoundTripNativePass(*this)));<br>
+#endif<br>
}<br>
} // end namespace lld<br>
<br>
<br>
______________________________<u></u>_________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/<u></u>mailman/listinfo/llvm-commits</a><br>
<br>
<br>
</blockquote>
<br>
<br></div></div><span class="HOEnZb"><font color="#888888">
-- <br>
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by the Linux Foundation<br>
<br>
</font></span></blockquote></div><br></div>