<html><head><meta http-equiv="Content-Type" content="text/html charset=iso-8859-1"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">That would be good, since you're there and all. :-)<div><br></div><div>-bw</div><div><br><div><div>On Oct 29, 2013, at 9:27 AM, MathOnNapkins . <<a href="mailto:mathonnapkins@gmail.com">mathonnapkins@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div dir="ltr"><div>Hi Bill,<br><br></div><div>As I was mostly intending this to be a janitorial sort of edit so that doxygen would actually pick it up in the first place, I hadn't put much thought into adding brief descriptions for routines in the patch. If you think it would be prudent I can try to adjust the patch to add (or partition off) brief descriptions.<br>
</div><div><br></div><div>Thanks,<br></div><div>~MoN / Dave<br></div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Tue, Oct 29, 2013 at 12:10 PM, Bill Wendling <span dir="ltr"><<a href="mailto:isanbard@gmail.com" target="_blank">isanbard@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Should you also put a "\brief" at the beginning?<br>
<br>
-bw<br>
<div><div class="h5"><br>
On Oct 29, 2013, at 8:53 AM, MathOnNapkins . <<a href="mailto:mathonnapkins@gmail.com">mathonnapkins@gmail.com</a>> wrote:<br>
<br>
> Dear All,<br>
><br>
> This is a small patch to convert normal comments in this file to document comments (// -> ///), as the descriptions for some of the routines were not being shown in the doxygen help.<br>
><br>
> Note: I am resubmitting this patch from a previous email, and the body of this email is a repeat. I am not trying to be a nuisance. I am only resubmitting because I noticed my previous email lacked a [PATCH] tag in the subject line, and it's my assumption that it was ignored or overlooked because of this. Please inform me if there is a protocol or etiquette I should further follow. I don't have commit access.<br>
><br>
> Thanks for your time,<br>
> ~MoN / Dave<br>
</div></div>> <target_lowering_doc_tag_missing_virtuals.patch>_______________________________________________<br>
> llvm-commits mailing list<br>
> <a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
<br>
</blockquote></div><br></div>
</blockquote></div><br></div></body></html>