<div dir="ltr">hi <div><br></div><div>Does that mean the problem I expressed here is now fixed ?<div><br></div><div><a href="http://lists.cs.uiuc.edu/pipermail/llvmdev/2013-July/064010.html" target="_blank">http://lists.cs.uiuc.edu/pipermail/llvmdev/2013-July/064010.html</a><br>

</div></div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Mon, Oct 28, 2013 at 9:33 PM, Arnold Schwaighofer <span dir="ltr"><<a href="mailto:aschwaighofer@apple.com" target="_blank">aschwaighofer@apple.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: arnolds<br>
Date: Mon Oct 28 20:33:50 2013<br>
New Revision: 193572<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=193572&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=193572&view=rev</a><br>
Log:<br>
SLPVectorizer: Use vector type for vectorized memory operations<br>
<br>
No test case, because with the current cost model we don't see a difference.<br>
An upcoming ARM memory cost model change will expose and test this bug.<br>
<br>
radar://15332579<br>
<br>
Modified:<br>
    llvm/trunk/lib/Transforms/Vectorize/SLPVectorizer.cpp<br>
<br>
Modified: llvm/trunk/lib/Transforms/Vectorize/SLPVectorizer.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Vectorize/SLPVectorizer.cpp?rev=193572&r1=193571&r2=193572&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Vectorize/SLPVectorizer.cpp?rev=193572&r1=193571&r2=193572&view=diff</a><br>

==============================================================================<br>
--- llvm/trunk/lib/Transforms/Vectorize/SLPVectorizer.cpp (original)<br>
+++ llvm/trunk/lib/Transforms/Vectorize/SLPVectorizer.cpp Mon Oct 28 20:33:50 2013<br>
@@ -1023,14 +1023,14 @@ int BoUpSLP::getEntryCost(TreeEntry *E)<br>
       // Cost of wide load - cost of scalar loads.<br>
       int ScalarLdCost = VecTy->getNumElements() *<br>
       TTI->getMemoryOpCost(Instruction::Load, ScalarTy, 1, 0);<br>
-      int VecLdCost = TTI->getMemoryOpCost(Instruction::Load, ScalarTy, 1, 0);<br>
+      int VecLdCost = TTI->getMemoryOpCost(Instruction::Load, VecTy, 1, 0);<br>
       return VecLdCost - ScalarLdCost;<br>
     }<br>
     case Instruction::Store: {<br>
       // We know that we can merge the stores. Calculate the cost.<br>
       int ScalarStCost = VecTy->getNumElements() *<br>
       TTI->getMemoryOpCost(Instruction::Store, ScalarTy, 1, 0);<br>
-      int VecStCost = TTI->getMemoryOpCost(Instruction::Store, ScalarTy, 1, 0);<br>
+      int VecStCost = TTI->getMemoryOpCost(Instruction::Store, VecTy, 1, 0);<br>
       return VecStCost - ScalarStCost;<br>
     }<br>
     default:<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div>